Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https to http redirect #596

Merged
merged 1 commit into from
May 13, 2015
Merged

Fix https to http redirect #596

merged 1 commit into from
May 13, 2015

Conversation

ryanseys
Copy link
Contributor

Fixes #559

Apparently GitHub Pages redirects https://googlecloudplatform.github.io/gcloud-node to http://googlecloudplatform.github.io/gcloud-node/ (note the trailing /) so if we change our URLs to include the / then it should remain on https.

$ curl -I https://googlecloudplatform.github.io/gcloud-node
HTTP/1.1 301 Moved Permanently
Server: github.com
Content-Type: text/html
Location: http://googlecloudplatform.github.io/gcloud-node/

I've already changed the URL in our repo too:

image

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2015
@jgeewax
Copy link
Contributor

jgeewax commented May 13, 2015

Woah -- good to know. LGTM

@ryanseys
Copy link
Contributor Author

I additionally contacted GitHub about the issue. I'll report back if they say anything but otherwise this should fix things on our end.

ryanseys added a commit that referenced this pull request May 13, 2015
@ryanseys ryanseys merged commit 67f795b into googleapis:master May 13, 2015
@ryanseys ryanseys deleted the https-fix branch May 13, 2015 17:18
@ryanseys
Copy link
Contributor Author

Here's the reply I received:

Hi Ryan,

Sorry for the trouble. Currently, we aren't officially supporting HTTPS on GitHub Pages.

While HTTPS requests may appear to work, our CDN provider is adding and removing the encryption at their end, and then the request is transmitted over the open internet from our CDN provider to our GitHub Pages infrastructure, creating the appearance of trustability.

This is why we do not yet officially support HTTPS for GitHub Pages. We definitely appreciate the feedback and I'll add a +1 to this item on out internal Feature Request List.

Thanks,
Jamie

So there's really no protection except just to make our users feel warm and fuzzy inside.

@jgeewax
Copy link
Contributor

jgeewax commented May 13, 2015

Ugh, thumbs down GitHub! But at least they'll look into it. Welp, warm fuzzy green lock thing is there at least...

sofisl pushed a commit that referenced this pull request Oct 11, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc](https://github.com/jsdoc/jsdoc) | [`^3.6.2` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>jsdoc/jsdoc</summary>

### [`v4.0.0`](https://github.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#&#8203;400-November-2022)

[Compare Source](https://github.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28)

-   JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes
    backwards-incompatible changes in the future, the major version will be incremented.
-   JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or
    plugin uses the `taffydb` package, see the
    [instructions for replacing `taffydb` with `@jsdoc/salty`](https://github.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template).
-   JSDoc now supports Node.js 12.0.0 and later.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-iot).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we switch all of our links to use https://googlecloudplatform.github.io/.... ?
3 participants