Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: var storage -> var gcs; #664

Merged
merged 1 commit into from
Jun 17, 2015
Merged

docs: var storage -> var gcs; #664

merged 1 commit into from
Jun 17, 2015

Conversation

stephenplusplus
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2015
@stephenplusplus stephenplusplus added docs api: storage Issues related to the Cloud Storage API. labels Jun 17, 2015
@ryanseys
Copy link
Contributor

Will review
On Jun 17, 2015 6:51 AM, "Stephen Sawchuk" notifications@github.com wrote:

Fixes #619 #619

You can view, comment on, or merge this pull request online at:

#664
Commit Summary

  • docs: var storage -> var gcs;

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#664.

@jgeewax
Copy link
Contributor

jgeewax commented Jun 17, 2015

LGTM

@ryanseys
Copy link
Contributor

You missed a few, one in the README and some throughout the tests.

/Users/ryanseys/gcloud-node/README.md:
  175  // global basis (see Authorization section above).
  176  
  177: var storage = gcloud.storage({
  178    keyFilename: '/path/to/keyfile.json',
  179    projectId: 'my-project'

/Users/ryanseys/gcloud-node/system-test/bigquery.js:
   29  var gcloud = require('../lib')(env);
   30  var bigquery = gcloud.bigquery();
   31: var storage = gcloud.storage();
   32  
   33  describe('BigQuery', function() {

/Users/ryanseys/gcloud-node/system-test/storage.js:
   30  
   31  var env = require('./env.js');
   32: var storage = require('../lib/storage')(env);
   33  
   34  var BUCKET_NAME = generateBucketName();

/Users/ryanseys/gcloud-node/test/storage/file.js:
 1330  
 1331      beforeEach(function() {
 1332:       var storage = bucket.storage;
 1333        storage.makeAuthorizedRequest_.getCredentials = function(callback) {
 1334          callback(null, credentials);
 ....
 1530  
 1531      beforeEach(function() {
 1532:       var storage = bucket.storage;
 1533        storage.makeAuthorizedRequest_.getCredentials = function(callback) {
 1534          callback(null, credentials);

/Users/ryanseys/gcloud-node/test/storage/index.js:
   26  
   27  describe('Storage', function() {
   28:   var storage;
   29  
   30    beforeEach(function() {

@stephenplusplus
Copy link
Contributor Author

I was going to leave the tests untouched, since the use of var storage makes more sense for us (the developers of this project) in the Storage->storage relationship.

Good catch on the readme.

@stephenplusplus
Copy link
Contributor Author

Got the readme.

@ryanseys
Copy link
Contributor

SGTM

ryanseys added a commit that referenced this pull request Jun 17, 2015
@ryanseys
Merge pull request #664 from stephenplusplus/spp--docs-storage-to-gcs
0822aaa 
docs: var storage -> var gcs;
@ryanseys ryanseys merged commit 0822aaa into googleapis:master Jun 17, 2015
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@gcf-owl-bot
chore: update v2.12.0 gapic-generator-typescript (#664)
ce4f9b0 
- [ ] Regenerate this pull request now.

Committer: @summer-ji-eng
PiperOrigin-RevId: 424244721

Source-Link: googleapis/googleapis@4b6b01f

Source-Link: googleapis/googleapis-gen@8ac83fb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@renovate-bot
chore(deps): update dependency sinon to v14 (#664)
655038f 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v14.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1400)

[Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.2...v14.0.0)

-   [`c2bbd826`](https://github.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00)
    Drop node 12 (Morgan Roderick)
    > And embrace Node 18
    >
    > See https://nodejs.org/en/about/releases/

*Released by Morgan Roderick on 2022-05-07.*

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-language).
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@renovate-bot @sofisl
chore(deps): update dependency sinon to v14 (#664)
59a040b 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v14.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1400)

[Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.2...v14.0.0)

-   [`c2bbd826`](https://github.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00)
    Drop node 12 (Morgan Roderick)
    > And embrace Node 18
    >
    > See https://nodejs.org/en/about/releases/

*Released by Morgan Roderick on 2022-05-07.*

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-language).
sofisl pushed a commit that referenced this pull request Nov 9, 2022
@gcf-owl-bot
chore: update v2.12.0 gapic-generator-typescript (#664)
ee0e765 
- [ ] Regenerate this pull request now.

Committer: @summer-ji-eng
PiperOrigin-RevId: 424244721

Source-Link: googleapis/googleapis@4b6b01f

Source-Link: googleapis/googleapis-gen@8ac83fb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9
This was referenced Nov 9, 2022
Closed
Merged
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@release-please
chore: release 3.2.1 (#664)
e65ec0c 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.2.1](https://www.github.com/googleapis/nodejs-dlp/compare/v3.2.0...v3.2.1) (2021-11-03)


### Bug Fixes

* **deps:** update dependency mime to v3 ([#663](https://www.github.com/googleapis/nodejs-dlp/issues/663)) ([5d33ead](https://www.github.com/googleapis/nodejs-dlp/commit/5d33ead5c207511a2ef3d268dd804eabc20408d8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @ryanseys @jgeewax @googlebot