FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

silvolu · 2014-07-30T20:37:32Z

...ctor.

lib/storage/index.js

@@ -146,6 +146,8 @@ ReadStream.prototype.pipe = function(dest, opts) {
 * create a bucket.
 */
 function Bucket(opts) {
+  if (!opts.bucketName)


rakyll · 2014-07-30T20:39:55Z

Styling comments, otherwise LGTM.

…tructor.

silvolu · 2014-07-30T20:44:55Z

Done!

FIX(storage): throw Error if bucket name is not passed to bucket constru...

* chore: ignore package-log.json * remove locky * renovateeee

…or (#68) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-loader](https://github.com/TypeStrong/ts-loader) | devDependencies | major | [`^6.2.1` -> `^7.0.0`](https://renovatebot.com/diffs/npm/ts-loader/6.2.2/7.0.0) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v7.0.0`](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v700) [Compare Source](https://github.com/TypeStrong/ts-loader/compare/v6.2.2...v7.0.0) - [Project reference support enhancements](https://github.com/TypeStrong/ts-loader/pull/1076) - thanks [@sheetalkamat](https://github.com/sheetalkamat)! - Following the end of life of Node 8, `ts-loader` no longer supports Node 8 **BREAKING CHANGE** </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-recommender).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webpack-cli](https://github.com/webpack/webpack-cli) | devDependencies | major | [`^3.3.11` -> `^4.0.0`](https://renovatebot.com/diffs/npm/webpack-cli/3.3.12/4.0.0) | --- ### Release Notes <details> <summary>webpack/webpack-cli</summary> ### [`v4.0.0`](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md#400-httpsgithubcomwebpackwebpack-clicomparewebpack-cli400-rc1webpack-cli400-2020-10-10) [Compare Source](https://github.com/webpack/webpack-cli/compare/v3.3.12...webpack-cli@4.0.0) ##### Bug Fixes - add compilation lifecycle in watch instance ([#1903](https://github.com/webpack/webpack-cli/issues/1903)) ([02b6d21](https://github.com/webpack/webpack-cli/commit/02b6d21eaa20166a7ed37816de716b8fc22b756a)) - cleanup `package-utils` package ([#1822](https://github.com/webpack/webpack-cli/issues/1822)) ([fd5b92b](https://github.com/webpack/webpack-cli/commit/fd5b92b3cd40361daec5bf4486e455a41f4c9738)) - cli-executer supplies args further up ([#1904](https://github.com/webpack/webpack-cli/issues/1904)) ([097564a](https://github.com/webpack/webpack-cli/commit/097564a851b36b63e0a6bf88144997ef65aa057a)) - exit code for validation errors ([59f6303](https://github.com/webpack/webpack-cli/commit/59f63037fcbdbb8934b578b9adf5725bc4ae1235)) - exit process in case of schema errors ([71e89b4](https://github.com/webpack/webpack-cli/commit/71e89b4092d953ea587cc4f606451ab78cbcdb93)) ##### Features - assign config paths in build dependencies in cache config ([#1900](https://github.com/webpack/webpack-cli/issues/1900)) ([7e90f11](https://github.com/webpack/webpack-cli/commit/7e90f110b119f36ef9def4f66cf4e17ccf1438cd)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-memcache).

@alexander-fenster

Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df

* chore(deps): upgrade gapic-generator-java to 2.4.1 PiperOrigin-RevId: 422607515 Source-Link: googleapis/googleapis@ba2ffd6 Source-Link: googleapis/googleapis-gen@73ba4ad Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzNiYTRhZGQyMzlhNjE5ZGE1NjdmZmJkNGU1NzMwZmRkNmRlMDRkMyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ript generator. (#68) * fix: Updating WORKSPACE files to use the newest version of the Typescript generator. Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file. PiperOrigin-RevId: 385101839 Source-Link: googleapis/googleapis@80f4042 Source-Link: googleapis/googleapis-gen@d3509d2 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add files for Network Connectivity v1 API. PiperOrigin-RevId: 387381480 Source-Link: googleapis/googleapis@6d27f5b Source-Link: googleapis/googleapis-gen@1c17f2e * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-network-connectivity/compare/v1.1.6...v1.2.0) (2021-07-30) ### Features * Add files for Network Connectivity v1 API. ([#68](https://www.github.com/googleapis/nodejs-network-connectivity/issues/68)) ([5028509](https://www.github.com/googleapis/nodejs-network-connectivity/commit/5028509d9a0ec649596b11a60906d23e68ff684d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^9.0.2` -> `^10.0.0`](https://renovatebot.com/diffs/npm/sinon/9.2.4/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/compatibility-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/confidence-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v10.0.0`](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md#1000--2021-03-22) [Compare Source](https://github.com/sinonjs/sinon/compare/v9.2.4...v10.0.0) ================== - Upgrade nise to 4.1.0 - Use [@sinonjs/eslint-config](https://github.com/sinonjs/eslint-config)[@4](https://github.com/4) => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bigquery-connection).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.1.4](https://www.github.com/googleapis/nodejs-retail/compare/v1.1.3...v1.1.4) (2021-07-01) ### Bug Fixes * **deps:** require google-gax v2.17.0 ([#66](https://www.github.com/googleapis/nodejs-retail/issues/66)) ([94fd8a8](https://www.github.com/googleapis/nodejs-retail/commit/94fd8a842f4fc7cfb480e72d4b3375ec0293cc09)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: lock files maintenance * chore: lock files maintenance

autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters.

rakyll reviewed Jul 30, 2014
View reviewed changes

lib/storage/index.js

@@ -146,6 +146,8 @@ ReadStream.prototype.pipe = function(dest, opts) {

* create a bucket.

*/

function Bucket(opts) {

if (!opts.bucketName)

This comment was marked as spam.

Sign in to view

FIX(storage): throw Error if bucket name is not passed to bucket cons…

0322432

…tructor.

rakyll pushed a commit that referenced this pull request Jul 30, 2014

Merge pull request #68 from silvolu/master

0765bdb

FIX(storage): throw Error if bucket name is not passed to bucket constru...

rakyll merged commit 0765bdb into googleapis:master Jul 30, 2014

snyk-bot mentioned this pull request Jan 29, 2022

[Snyk] Upgrade figures from 3.2.0 to 4.0.0 RebelTat/google-cloud-node#4

Open

mikolajroszak mentioned this pull request May 7, 2022

[Snyk] Upgrade figures from 3.2.0 to 4.0.1 mikolajroszak/google-cloud-node#4

Open

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

Re-generate library using /synth.py (#68)

3eb2c29

sofisl pushed a commit that referenced this pull request Sep 27, 2022

chore: require node 8 for samples (#68)

8e0b8e0

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

Re-generate library using /synth.py (#68)

2838bfe

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

Re-generate library using /synth.py (#68)

01acedc

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

fix(deps): update dependency yargs to v12 (#68)

c562996

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: ignore package-lock.json (#68)

1fc2f5f

* chore: ignore package-log.json * remove locky * renovateeee

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-monitoring-dashboards #3408

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

fix: remove eslint, update gax, fix generated protos, run the generat…

257b30f

…or (#68) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

This was referenced Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

migrate code from googleapis/nodejs-memcache #3412

Merged

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: update gapic-generator-typescript to v1.3.2 (#68)

0d03351

Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-service-usage #3610

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

docs(nodejs): version support policy edits (#1346) (#68)

c1ea078

sofisl pushed a commit that referenced this pull request Nov 11, 2022

build(node): update deps used during postprocessing (#1243) (#68)

bed1144

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): use google-gax v3.5.2 (#68)

1151411

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-vmmigration #3613

Merged

migrate code from googleapis/nodejs-org-policy #3614

Merged

migrate code from googleapis/nodejs-private-catalog #3616

Merged

migrate code from googleapis/nodejs-managed-identities #3642

Merged

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

migrate code from googleapis/nodejs-orchestration-airflow #3644

Merged

sofisl pushed a commit that referenced this pull request Nov 16, 2022

fix(deps): bump google-gax to 1.7.5 (#68)

4fd737e

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

migrate code from googleapis/nodejs-retail #3648

Merged

sofisl mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-security-center #3669

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 18, 2022

Release @google-cloud/security-center v0.3.0 (#68)

9712c1e

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

chore: lock files maintenance (#68)

bd1a20e

* chore: lock files maintenance * chore: lock files maintenance

sofisl pushed a commit that referenced this pull request Jan 26, 2023

build: adds UNORDERED_LIST enum (#68)

a8932f0

autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters.

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

fix: drop support for node.js 4.x and 9.x (#68)

a167563

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

silvolu commented Jul 30, 2014

This comment was marked as spam.

rakyll commented Jul 30, 2014

silvolu commented Jul 30, 2014

FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

FIX(storage): throw Error if bucket name is not passed to bucket constru... #68

Conversation

silvolu commented Jul 30, 2014

This comment was marked as spam.

rakyll commented Jul 30, 2014

silvolu commented Jul 30, 2014