Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Don't provide multiple methods for file writing #70

Merged
merged 4 commits into from
Jul 31, 2014
Merged

storage: Don't provide multiple methods for file writing #70

merged 4 commits into from
Jul 31, 2014

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Jul 31, 2014

This is a proposal, don't merge if you don't like it.

@silvolu
Copy link
Contributor

silvolu commented Jul 31, 2014

We might want to keep the option to upload a file by passing the path to the file, for the 'I just want to upload this file' scenario. What do you think?

@rakyll
Copy link
Contributor Author

rakyll commented Jul 31, 2014

Should we call it bucket.writeFile or provide a filename option?

bucket.write(name, { filename: '/path/to/whatever' }, callback);

@silvolu
Copy link
Contributor

silvolu commented Jul 31, 2014

I like the idea of having only one method, so filename option sounds good!

@rakyll
Copy link
Contributor Author

rakyll commented Jul 31, 2014

Done, PTAL.

@silvolu
Copy link
Contributor

silvolu commented Jul 31, 2014

LGTM

silvolu added a commit that referenced this pull request Jul 31, 2014
@silvolu
Merge pull request #70 from rakyll/writeinterfaces
6cd5692 
storage: Don't provide multiple methods for file writing
@silvolu silvolu merged commit 6cd5692 into googleapis:master Jul 31, 2014
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Open
@mikolajroszak mikolajroszak mentioned this pull request May 7, 2022
Open
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@JustinBeckwith @alexander-fenster
Retry npm install in CI (#70)
932fc1f
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@JustinBeckwith @alexander-fenster
Retry npm install in CI (#70)
4e627d4
This was referenced Oct 5, 2022
Closed
Closed
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@JustinBeckwith @alexander-fenster
Retry npm install in CI (#70)
2b3001c
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@renovate @JustinBeckwith
chore(deps): lock file maintenance (#70)
6e36989
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@renovate @jkwlui
chore(deps): update dependency eslint-config-prettier to v3 (#70)
bdc2af5
This was referenced Oct 12, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@renovate-bot @bcoe
chore(deps): update dependency eslint-plugin-node to v11 (#70)
d64be2e
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation
chore: update proto namespaces (#70)
e7970e0
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation
chore: clean up Node.js TOC for cloud-rad (#70)
f42e0b6 
* chore: clean up Node.js TOC for cloud-rad

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Oct 21 09:26:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: f96d3b455fe27c3dc7bc37c3c9cd27b1c6d269c8
Source-Link: googleapis/synthtool@f96d3b4

* chore: fix Node.js TOC for cloud-rad

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Oct 21 12:01:24 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 901ddd44e9ef7887ee681b9183bbdea99437fdcc
Source-Link: googleapis/synthtool@901ddd4
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@JustinBeckwith
chore: drop contributors from multiple places (#70)
b7645b6
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@fhinkel
chore(nodejs): update client ref docs link in metadata (#70)
38a794c
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
build(node): update deps used during postprocessing (#1243) (#70)
0a9c4be
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@bcoe
fix(deps): google-gax v2.17.1 (#70)
f3919ab
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 0.2.5 (#71)
176747d 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.2.5](https://www.github.com/googleapis/nodejs-service-management/compare/v0.2.4...v0.2.5) (2021-07-12)


### Bug Fixes

* **deps:** google-gax v2.17.1 ([#70](https://www.github.com/googleapis/nodejs-service-management/issues/70)) ([fc4f996](https://www.github.com/googleapis/nodejs-service-management/commit/fc4f99666252f8f06f399438aedebb6e5502f2e9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 1.2.0 (#70)
0c74237 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.2.0](https://www.github.com/googleapis/nodejs-service-control/compare/v1.1.4...v1.2.0) (2021-08-23)


### Features

* turns on self-signed JWT feature flag ([#69](https://www.github.com/googleapis/nodejs-service-control/issues/69)) ([511f88b](https://www.github.com/googleapis/nodejs-service-control/commit/511f88b92881633b55a3528715f4453b23ce1765))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 11, 2022
chore: fix the wrong post processor image (#70)
ef1703b
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot
chore(deps): update dependency jsdoc to v4 (#70)
a9947f4 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc](https://github.com/jsdoc/jsdoc) | [`^3.6.6` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>jsdoc/jsdoc</summary>

### [`v4.0.0`](https://github.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#&#8203;400-November-2022)

[Compare Source](https://github.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28)

-   JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes
    backwards-incompatible changes in the future, the major version will be incremented.
-   JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or
    plugin uses the `taffydb` package, see the
    [instructions for replacing `taffydb` with `@jsdoc/salty`](https://github.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template).
-   JSDoc now supports Node.js 12.0.0 and later.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-vmmigration).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9-->
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 12, 2022
@renovate-bot
chore(deps): update dependency jsdoc-region-tag to v2 (#70)
182a597 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc-region-tag](https://github.com/googleapis/jsdoc-region-tag) | [`^1.0.6` -> `^2.0.0`](https://renovatebot.com/diffs/npm/jsdoc-region-tag/1.3.1/2.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/compatibility-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/confidence-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/jsdoc-region-tag</summary>

### [`v2.0.0`](https://github.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;200-httpsgithubcomgoogleapisjsdoc-region-tagcomparev131v200-2022-05-20)

[Compare Source](https://github.com/googleapis/jsdoc-region-tag/compare/v1.3.1...v2.0.0)

##### ⚠ BREAKING CHANGES

-   update library to use Node 12 ([#&#8203;107](https://github.com/googleapis/jsdoc-region-tag/issues/107))

##### Build System

-   update library to use Node 12 ([#&#8203;107](https://github.com/googleapis/jsdoc-region-tag/issues/107)) ([5b51796](https://github.com/googleapis/jsdoc-region-tag/commit/5b51796771984cf8b978990025f14faa03c19923))

##### [1.3.1](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.3.0...v1.3.1) (2021-08-11)

##### Bug Fixes

-   **build:** migrate to using main branch ([#&#8203;79](https://www.github.com/googleapis/jsdoc-region-tag/issues/79)) ([5050615](https://www.github.com/googleapis/jsdoc-region-tag/commit/50506150b7758592df5e389c6a5c3d82b3b20881))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-filestore).
@sofisl sofisl mentioned this pull request Nov 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 2.1.2 (#70)
05fa5dc 
🤖 I have created a release *beep* *boop*
---


## [2.1.2](https://github.com/googleapis/nodejs-orchestration-airflow/compare/v2.1.1...v2.1.2) (2022-11-15)


### Bug Fixes

* **deps:** Use google-gax v3.5.2 ([#76](https://github.com/googleapis/nodejs-orchestration-airflow/issues/76)) ([5d9c78a](https://github.com/googleapis/nodejs-orchestration-airflow/commit/5d9c78a81d9ae07244f696ac7a9d211964fd62b2))
* Preserve default values in x-goog-request-params header ([#69](https://github.com/googleapis/nodejs-orchestration-airflow/issues/69)) ([cdef154](https://github.com/googleapis/nodejs-orchestration-airflow/commit/cdef154d8a51c446cdc16b61660f18e6123b8168))
* Regenerated protos JS and TS definitions ([#79](https://github.com/googleapis/nodejs-orchestration-airflow/issues/79)) ([b0ef563](https://github.com/googleapis/nodejs-orchestration-airflow/commit/b0ef56303b2e61a7a1a8fb505916682631e8beec))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 16, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 1.1.5 (#70)
0ef5edb 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Nov 30, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 30, 2022
@release-please @alexander-fenster
chore: release 1.5.0 (#70)
0d116f0 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@JustinBeckwith
feat: add synth script and regenerate (#70)
613c469
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@alexander-fenster @callmehiphop
chore: lock files maintenance (#70)
aff8ba4 
* chore: lock files maintenance

* chore: lock files maintenance
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@alexander-fenster @callmehiphop
chore: lock files maintenance (#70)
24f0310 
* chore: lock files maintenance

* chore: lock files maintenance
sofisl pushed a commit that referenced this pull request Jan 26, 2023
@telpirion
feat: adds v1 version of library (#70)
cdd198d 
* feat: adds v1 version of library
* fix: workaround for test failures (added run.ts file)
@sofisl sofisl mentioned this pull request Jan 26, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@renovate @JustinBeckwith
chore(deps): lock file maintenance (#70)
14f3910
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakyll @silvolu