Add Google Cloud DNS #706

stephenplusplus · 2015-07-06T20:11:37Z

Fixes #486

To Dos

Docs: https://stephenplusplus.github.io/gcloud-node-gh-pages-again/#/docs/master/dns

system-test/dns.js

+      });
+    });
+
+    it('should replace records', function(done) {


stephenplusplus · 2015-07-21T14:44:08Z

Assigned to @callmehiphop for a review, please. Probably easiest to start with the docs, and make sure the API looks sane.

lib/dns/index.js

+ * @example
+ * dns.getZones(function(err, zones, apiResponse) {});
+ */
+DNS.prototype.getZones = function(query, callback) {


stephenplusplus · 2015-07-21T15:48:37Z

@jgeewax Since we're trapped on what we can do with system testing (re: the error The 'gcloud-node.com.' managed zone is not available to be created.), here are the options we have that I can think of:

Look for a GCLOUD_TESTS_DNS_DOMAIN env var and use it for system testing. This is how it is in this PR currently, and how I've been testing with my stephenplusplus.com. domain (which has yet to run into the issues gcloud-node.com. has)
If the env var is set, try to create a zone. If it fails with the error above, try to get a list of zones that already exist, and use one of them to complete the tests that don't involve creating/deleting zones with.
If we can't get a zone, or any of the above failed, skip the DNS tests.

It's not exactly pretty to make our tests run like that, but it's possible.

lib/dns/zone.js

+  var path = '/managedZones/' + this.name;
+  this.makeReq_('DELETE', path, null, null, function(err, resp) {
+    callback(err, resp);
+  });


jgeewax · 2015-07-21T16:03:52Z

I can't find anywhere in any of my projects that have a zone for gcloud-node.com ... I opened a ticket asking WTF is going on... because that's super weird. If you know a project that has the zone created... lmk... I'd really like to use gcloud-node as the demo domain...

lib/dns/zone.js

+  }
+
+  if (query.sort) {
+    query.sortBy = 'changeSequence';


re: googleapis#706 (comment)

callmehiphop · 2015-07-21T18:27:55Z

LGTM

stephenplusplus · 2015-07-24T18:12:52Z

If you know a project that has the zone created... lmk... I'd really like to use gcloud-node as the demo domain...

Don't know of one, and me too re: gcloud-node.com. I assigned to you since this is our last step before merging. If you prefer we merge with the system tests shut off for now and track the domain stuff in a new issue, that's cool too.

stephenplusplus · 2015-07-29T21:21:41Z

@jgeewax As this PR sits now, our system tests work like this:

Is an env var called "GCLOUD_TESTS_DNS_DOMAIN" set?
- Yes: run the DNS system tests using that domain
- No: don't run the DNS system tests

Testing locally with GCLOUD_TESTS_DNS_DOMAIN set to gcloud-node.com. works for me now. I set the env var in travis, too. Merging this should run the tests and "just work". Want to press the green button? :)

jgeewax · 2015-07-29T21:30:41Z

SGTM - but I'll let you do the merge :P

Add Google Cloud DNS

stephenplusplus · 2015-07-29T22:01:02Z

Yolo!

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-video-intelligence).

Regenerated the library using [gapic-generator-typescript](https://github.com/googleapis/gapic-generator-typescript) v1.2.1.

stephenplusplus added api: dns Issues related to the Cloud DNS API. don't merge labels Jul 6, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2015

stephenplusplus reviewed Jul 6, 2015
View reviewed changes

system-test/dns.js

});

});

it('should replace records', function(done) {

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--dns branch 11 times, most recently from e964fe8 to bc19a17 Compare July 20, 2015 15:01

stephenplusplus force-pushed the spp--dns branch 3 times, most recently from d6348d9 to c42fdfb Compare July 21, 2015 14:42

stephenplusplus assigned callmehiphop Jul 21, 2015

stephenplusplus removed the don't merge label Jul 21, 2015

callmehiphop reviewed Jul 21, 2015
View reviewed changes

lib/dns/index.js

* @example

* dns.getZones(function(err, zones, apiResponse) {});

*/

DNS.prototype.getZones = function(query, callback) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop reviewed Jul 21, 2015
View reviewed changes

lib/dns/zone.js

var path = '/managedZones/' + this.name;

this.makeReq_('DELETE', path, null, null, function(err, resp) {

callback(err, resp);

});

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop reviewed Jul 21, 2015
View reviewed changes

lib/dns/zone.js

}

if (query.sort) {

query.sortBy = 'changeSequence';

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this pull request Jul 21, 2015

remove unnecessary sort property

b2f2839

re: googleapis#706 (comment)

callmehiphop mentioned this pull request Jul 21, 2015

Add Google Compute Engine support #721

Closed

stephenplusplus force-pushed the spp--dns branch from 50b5447 to 44cb837 Compare July 22, 2015 19:45

stephenplusplus assigned jgeewax and unassigned callmehiphop Jul 24, 2015

stephenplusplus mentioned this pull request Jul 24, 2015

Pass apiResponse along with errors #741

Merged

stephenplusplus force-pushed the spp--dns branch from 44cb837 to 3a6bf46 Compare July 28, 2015 01:11

Add Google Cloud DNS

ad63809

stephenplusplus force-pushed the spp--dns branch from 3a6bf46 to ad63809 Compare July 29, 2015 16:30

stephenplusplus added a commit that referenced this pull request Jul 29, 2015

Merge pull request #706 from stephenplusplus/spp--dns

f57d3b1

Add Google Cloud DNS

stephenplusplus merged commit f57d3b1 into googleapis:master Jul 29, 2015

quartzmo mentioned this pull request Sep 10, 2015

DNS replace records by criteria googleapis/google-cloud-ruby#298

Closed

JustinBeckwith unassigned jgeewax Sep 19, 2018

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

migrate code from googleapis/nodejs-dialogflow #3546

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix: do not modify options object, use defaultScopes (#706)

46f8bdc

Regenerated the library using [gapic-generator-typescript](https://github.com/googleapis/gapic-generator-typescript) v1.2.1.

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore(deps): update dependency webpack-cli to v5 (#706)

66a134f

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

WontonSam mentioned this pull request Sep 17, 2024

[Snyk] Upgrade @google-cloud/sql from 0.8.0 to 0.18.0 WontonSam/Bekki13-cloud-node#2708

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Google Cloud DNS #706

Add Google Cloud DNS #706

stephenplusplus commented Jul 6, 2015

This comment was marked as spam.

stephenplusplus commented Jul 21, 2015

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Jul 21, 2015

This comment was marked as spam.

This comment was marked as spam.

jgeewax commented Jul 21, 2015

This comment was marked as spam.

This comment was marked as spam.

callmehiphop commented Jul 21, 2015

stephenplusplus commented Jul 24, 2015

stephenplusplus commented Jul 29, 2015

jgeewax commented Jul 29, 2015

stephenplusplus commented Jul 29, 2015

Add Google Cloud DNS #706

Add Google Cloud DNS #706

Conversation

stephenplusplus commented Jul 6, 2015

To Dos

This comment was marked as spam.

stephenplusplus commented Jul 21, 2015

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Jul 21, 2015

This comment was marked as spam.

This comment was marked as spam.

jgeewax commented Jul 21, 2015

This comment was marked as spam.

This comment was marked as spam.

callmehiphop commented Jul 21, 2015

stephenplusplus commented Jul 24, 2015

stephenplusplus commented Jul 29, 2015

jgeewax commented Jul 29, 2015

stephenplusplus commented Jul 29, 2015