only show inner methods when class is active #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
force-pushed
the
spp--docs-collapsible-nav
branch
2 times, most recently
from
30d78df
to
ff3430e
Compare
| @@ -84,7 +84,7 @@ <h4 class="list-item--heading">API</h4> | |||
| ng-href="{{page.url}}"> | |||
| {{page.title}} | |||
| </a> | |||
| <ul class="sub-sections" ng-if="page.pages"> | |||
| <ul class="sub-sections" ng-if="page.pages" ng-show="isActiveClass(page)"> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Do we want to add an arrow or something to indicate that the items are expandable? |
stephenplusplus
force-pushed
the
spp--docs-collapsible-nav
branch
from
ff3430e
to
44c3639
Compare
|
Only using the |
I think this would send the wrong message, UX wise. With an arrow, the impression is a menu will be expanded, but another page won't load. To go the expand/collapse route, it would force these :( changes:
|
|
@jgeewax let me know if this is what you had in mind: http://stephenplusplus.github.io/gcloud-node/#/docs/v0.16.0 |
callmehiphop
added a commit
that referenced
this pull request
Jul 27, 2015
only show inner methods when class is active
|
👍 |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^11.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/sinon/11.1.2/12.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v12.0.1`](https://github.com/sinonjs/sinon/blob/master/CHANGES.md#​1201) [Compare Source](https://github.com/sinonjs/sinon/compare/v12.0.0...v12.0.1) - [`3f598221`](https://github.com/sinonjs/sinon/commit/3f598221045904681f2b3b3ba1df617ed5e230e3) Fix issue with npm unlink for npm version > 6 (Carl-Erik Kopseng) > 'npm unlink' would implicitly unlink the current dir > until version 7, which requires an argument - [`51417a38`](https://github.com/sinonjs/sinon/commit/51417a38111eeeb7cd14338bfb762cc2df487e1b) Fix bundling of cjs module ([#​2412](https://github.com/sinonjs/sinon/issues/2412)) (Julian Grinblat) > - Fix bundling of cjs module > > - Run prettier *Released by [Carl-Erik Kopseng](https://github.com/fatso83) on 2021-11-04.* #### 12.0.0 ### [`v12.0.0`](https://github.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) [Compare Source](https://github.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-translate).
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
](https://renovatebot.com){kind=link}
* chore(deps): update dependency uuid to v9 * test: fix samples test Co-authored-by: Alexander Fenster <github@fenster.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
This will hide the sub-classes of a parent class (BigQuery, Datastore, etc) until it is active.
Preview: http://stephenplusplus.github.io/gcloud-node/#/docs/