Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had issues with Pub/Sub tests flaking out, and today we ran into them again: https://travis-ci.org/GoogleCloudPlatform/gcloud-node/builds/73278785#L3237
What appears to be happening is when we pull for a message with returnImmediately:false, no messages are ever returned, and the test times out.
History:
#332
#377
The way it was working until today seemed cleaner, which was basically:
We used to run them like this:
This PR runs them like this:
I played with the ordering of publishes and pulls, with returnImmediately to true and false, with different amounts of messages (anywhere from 1-10), with publishing multiple messages in one API call vs many, and this was the only combination of all of the above that I could find that worked.
@tmatsuo -- your wisdom is very welcome :)