Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use split-array-stream #777

Merged

Conversation

stephenplusplus
Copy link
Contributor

split-array-stream makes it a little easier to handle pushing results from an array to a stream.

This also simplifies the logic in DatastoreRequest.get to always use stream mode behind the scenes, even if the user provides a callback.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2015
@stephenplusplus stephenplusplus force-pushed the spp--use-split-array-stream branch from 30c828f to 06cacc9 Compare August 2, 2015 16:39
@stephenplusplus stephenplusplus force-pushed the spp--use-split-array-stream branch from 06cacc9 to d1485ca Compare August 2, 2015 17:07
callmehiphop added a commit that referenced this pull request Aug 3, 2015
@callmehiphop callmehiphop merged commit 4b5db8b into googleapis:master Aug 3, 2015
@callmehiphop
Copy link
Contributor

👍

sofisl pushed a commit that referenced this pull request Jan 10, 2023
PiperOrigin-RevId: 477776089
Source-Link: googleapis/googleapis@57062cd
Source-Link: googleapis/googleapis-gen@99b76b5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTliNzZiNTJiMTM4YTc5Mjc3ZmNhYzhjNDY2NDRiODE1YzdhMzdkNyJ9
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 24, 2023
…ript generator. (#777)

Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file.

PiperOrigin-RevId: 385101839

Source-Link: googleapis/googleapis@80f4042

Source-Link: googleapis/googleapis-gen@d3509d2
sofisl pushed a commit that referenced this pull request Jan 24, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [4.5.5](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.4...v4.5.5) (2021-07-21)


### Bug Fixes

* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#777](https://www.github.com/googleapis/nodejs-speech/issues/777)) ([8911be0](https://www.github.com/googleapis/nodejs-speech/commit/8911be0cc600b4d16af5a809800118be07f8483b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Jan 25, 2023
…ript generator. (#777)

Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file.

PiperOrigin-RevId: 385101839

Source-Link: googleapis/googleapis@80f4042

Source-Link: googleapis/googleapis-gen@d3509d2
sofisl pushed a commit that referenced this pull request Jan 25, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### [4.5.5](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.4...v4.5.5) (2021-07-21)


### Bug Fixes

* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#777](https://www.github.com/googleapis/nodejs-speech/issues/777)) ([8911be0](https://www.github.com/googleapis/nodejs-speech/commit/8911be0cc600b4d16af5a809800118be07f8483b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Sep 13, 2023
* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/batch_predict.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/delete_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/delete_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/deploy_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/export_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/get_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/get_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/get_model_evaluation.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/get_operation_status.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/import_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_entity_extraction_create_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_entity_extraction_create_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_entity_extraction_predict.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_sentiment_analysis_create_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_sentiment_analysis_create_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_entity_extraction_predict.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_text_classification_create_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_text_classification_create_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/language_text_classification_predict.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/list_datasets.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/list_model_evaluations.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/list_models.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/list_operation_status.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/translate_create_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/translate_create_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/translate_predict.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/undeploy_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_classification_create_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_classification_create_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_classification_deploy_model_node_count.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_classification_predict.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_object_detection_create_dataset.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_object_detection_create_model.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_object_detection_deploy_model_node_count.js

* chore: remove samples

This file has moved https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/automl/vision_object_detection_predict.js

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: remove samples tests

Delete samples tests; these are tested at their new location.

* chore: remove samples tests

* chore: remove samples tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: re-add test folder

Oops, I broke tests by deleting too much, re-adding.

* chore: re-add test files

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants