Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming all uses of authorize to authenticate #846

Closed
wants to merge 2 commits into from
Closed

Renaming all uses of authorize to authenticate #846

wants to merge 2 commits into from

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 2, 2015

This is a mess, so I tried to make it "reproducible".

Fixes #841

Some of the links will be broken unless the language and links paths in gcloud-common are also updated.


To "find" them all I used

git grep -i authori

and then to replace, it was

git grep -l Authorization | xargs sed -i 's/Authorization/Authentication/g'
git grep -l authorization | xargs sed -i 's/authorization/authentication/g'
git grep -l Authorizing | xargs sed -i 's/Authorizing/Authenticating/g'
git grep -l authorizing | xargs sed -i 's/authorizing/authenticating/g'
git grep -l Authorized | xargs sed -i 's/Authorized/Authenticated/g'
git grep -l authorized | xargs sed -i 's/authorized/authenticated/g'
git grep -l authorize | xargs sed -i 's/authorize/authenticate/g'

(There is probably a smarter way to make case-insensitive / case-matching replacements with sed, I just didn't.)

Then this process touched the license so I had to do

git checkout -- COPYING

To check this all "quickly" I used

git diff --color-words

and finally to do the file renames I did

git ls-files | grep -i authori

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2015
@stephenplusplus
Copy link
Contributor

Man... words.

Thanks very much for doing this. I think we can take it over from here to get the tests to pass. (@callmehiphop - how about renaming all of our makeAuthenticatedRequest_ to just request or something less wordy?)

@callmehiphop
Copy link
Contributor

Sure makeApiRequest_?

@stephenplusplus
Copy link
Contributor

Yeah, that's good enough 👍 I think in a separate issue soon, we should once and for all clear up the multiple "makeRequest-ish" methods we have, and just follow a pattern. Will make an issue for that.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 2, 2015

Sorry for being a bad OS citizen, I never ran npm test. I recall trying to do it about 12 months ago and having a really bad time (TM).

@stephenplusplus
Copy link
Contributor

#861 will take this over. Thanks @dhermes!

@dhermes dhermes deleted the authorize-to-authenticate branch September 14, 2015 20:48
@dhermes
Copy link
Contributor Author

dhermes commented Sep 14, 2015

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants