test(storage): add regression tests. #88

silvolu · 2014-08-01T19:44:51Z

No description provided.

regression/storage.js

+      bucket.write(fileName, { filename: pathToLogoFile }, function(err, fileObject, resp) {
+        if (err) { return done(err); }
+        assert(fileObject);
+        bucket.remove(fileName, function(err) {


* add checks for file content based on md5 hash * use tmp module to manage temp files * use async module for batch tasks

silvolu · 2014-08-02T00:20:19Z

Done, PTAL.
Thanks for pointing me to async! I'll refactor other tests using it asap.

rakyll · 2014-08-05T01:09:13Z

Please add a TODO for async, so I can merge.

rakyll · 2014-08-05T02:22:22Z

Added TODOs and merged.

* fix!: Fix the resource annotations for GetRepositoryRequest BREAKING CHANGE: This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway. PiperOrigin-RevId: 403028264 Source-Link: googleapis/googleapis@9bac62d Source-Link: googleapis/googleapis-gen@4f54454 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY1NDQ1NGI2NDliY2VkZWExNGJiMDE5NTVhNjU4NTBjZTkwNmQ5YiJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.2.0...v1.2.1) (2021-10-14) ### ⚠ BREAKING CHANGES * * fix!: Fix the resource annotations for GetRepositoryRequest ### Bug Fixes * Fix the resource annotations for GetRepositoryRequest ([#88](https://www.github.com/googleapis/nodejs-artifact-registry/issues/88)) ([80ba28f](https://www.github.com/googleapis/nodejs-artifact-registry/commit/80ba28f3d3df7ac211edd82b10bb966f61f787f6)) ### meta * release at 1.2.1 ([#90](https://www.github.com/googleapis/nodejs-artifact-registry/issues/90)) ([314bef4](https://www.github.com/googleapis/nodejs-artifact-registry/commit/314bef484ad3cc0aa7f673c9674115689f529d88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* fix!: Fix the resource annotations for GetRepositoryRequest BREAKING CHANGE: This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway. PiperOrigin-RevId: 403028264 Source-Link: googleapis/googleapis@9bac62d Source-Link: googleapis/googleapis-gen@4f54454 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY1NDQ1NGI2NDliY2VkZWExNGJiMDE5NTVhNjU4NTBjZTkwNmQ5YiJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.2.0...v1.2.1) (2021-10-14) ### ⚠ BREAKING CHANGES * * fix!: Fix the resource annotations for GetRepositoryRequest ### Bug Fixes * Fix the resource annotations for GetRepositoryRequest ([#88](https://www.github.com/googleapis/nodejs-artifact-registry/issues/88)) ([80ba28f](https://www.github.com/googleapis/nodejs-artifact-registry/commit/80ba28f3d3df7ac211edd82b10bb966f61f787f6)) ### meta * release at 1.2.1 ([#90](https://www.github.com/googleapis/nodejs-artifact-registry/issues/90)) ([314bef4](https://www.github.com/googleapis/nodejs-artifact-registry/commit/314bef484ad3cc0aa7f673c9674115689f529d88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^11.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/sinon/11.1.2/12.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/compatibility-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/confidence-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v12.0.1`](https://github.com/sinonjs/sinon/blob/master/CHANGES.md#1201) [Compare Source](https://github.com/sinonjs/sinon/compare/v12.0.0...v12.0.1) - [`3f598221`](https://github.com/sinonjs/sinon/commit/3f598221045904681f2b3b3ba1df617ed5e230e3) Fix issue with npm unlink for npm version > 6 (Carl-Erik Kopseng) > 'npm unlink' would implicitly unlink the current dir > until version 7, which requires an argument - [`51417a38`](https://github.com/sinonjs/sinon/commit/51417a38111eeeb7cd14338bfb762cc2df487e1b) Fix bundling of cjs module ([#2412](https://github.com/sinonjs/sinon/issues/2412)) (Julian Grinblat) > - Fix bundling of cjs module > > - Run prettier *Released by [Carl-Erik Kopseng](https://github.com/fatso83) on 2021-11-04.* #### 12.0.0 ### [`v12.0.0`](https://github.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) [Compare Source](https://github.com/sinonjs/sinon/compare/v11.1.2...v12.0.0) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-service-control).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped) | [`^8.2.2` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-service-usage).

* chore(main): release 2.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: lock files maintenance * chore: lock files maintenance * chore: lock files maintenance * try with node user

test(storage): add regression tests.

efb3d7d

rakyll reviewed Aug 1, 2014
View reviewed changes

regression/storage.js

bucket.write(fileName, { filename: pathToLogoFile }, function(err, fileObject, resp) {

if (err) { return done(err); }

assert(fileObject);

bucket.remove(fileName, function(err) {

This comment was marked as spam.

Sign in to view

refactor(storage): several improvements to regression tests.

f2914be

* add checks for file content based on md5 hash * use tmp module to manage temp files * use async module for batch tasks

rakyll added this to the M1: core, datastore & storage milestone Aug 5, 2014

rakyll merged commit f2914be into googleapis:master Aug 5, 2014

jgeewax added testing api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. and removed api: datastore Issues related to the Datastore API. labels Feb 2, 2015

jgeewax modified the milestones: M1: core, datastore & storage, Storage Stable Feb 2, 2015

snyk-bot mentioned this pull request Jan 29, 2022

[Snyk] Upgrade figures from 3.2.0 to 4.0.0 RebelTat/google-cloud-node#4

Open

mikolajroszak mentioned this pull request May 7, 2022

[Snyk] Upgrade figures from 3.2.0 to 4.0.1 mikolajroszak/google-cloud-node#4

Open

release-please bot mentioned this pull request Sep 14, 2022

chore: release main #3352

Merged

sofisl pushed a commit that referenced this pull request Oct 11, 2022

Re-generate library using /synth.py (#88)

c8b8404

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-api-gateway #3606

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-appengine-admin #3607

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore(cloud-rad): delete api-extractor config (#88)

74979bb

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-service-control #3609

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-service-usage #3610

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-tpu #3612

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-private-catalog #3616

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore: release 1.5.0 (#88)

323ff02

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

migrate code from googleapis/nodejs-retail #3648

Merged

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore(nodejs): update client ref docs link in metadata (#88)

400dd1b

sofisl pushed a commit that referenced this pull request Nov 17, 2022

chore: lock files maintenance (#88)

146a3b9

* chore: lock files maintenance * chore: lock files maintenance * chore: lock files maintenance * try with node user

This was referenced Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

refactor: update generated sources (#88)

f2b3a0d

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

chore: Re-generate library using /synth.py (#88)

906cf45

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

fix(build): fix system key decryption (#88)

b704b04

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: use es classes (#88)

6efc42f

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

mikolajroszak mentioned this pull request May 7, 2024

[Snyk] Upgrade figures from 3.2.0 to 6.1.0 mikolajroszak/google-cloud-node#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(storage): add regression tests. #88

test(storage): add regression tests. #88

silvolu commented Aug 1, 2014

This comment was marked as spam.

silvolu commented Aug 2, 2014

rakyll commented Aug 5, 2014

rakyll commented Aug 5, 2014

test(storage): add regression tests. #88

test(storage): add regression tests. #88

Conversation

silvolu commented Aug 1, 2014

This comment was marked as spam.

silvolu commented Aug 2, 2014

rakyll commented Aug 5, 2014

rakyll commented Aug 5, 2014