datastore: don't require auth with local datastore server #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| */ | ||
| Dataset.determineApiEndpoint_ = function(options) { | ||
| var apiEndpoint = 'https://www.googleapis.com'; | ||
| Dataset.prototype.determineApiEndpoint_ = function(customApiEndpoint) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
callmehiphop
added a commit
that referenced
this pull request
Nov 12, 2015
datastore: don't require auth with local datastore server
|
👍 |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.8](https://www.github.com/googleapis/nodejs-vision/compare/v2.3.7...v2.3.8) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#939](https://www.github.com/googleapis/nodejs-vision/issues/939)) ([21d59e3](https://www.github.com/googleapis/nodejs-vision/commit/21d59e39ba66eb14db467e101477cba692a67d44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936
When a service object is created (such as a Dataset object), we have the choice of telling our "makeAuthenticatedRequestFactory" function that we don't care about the authentication part via an option called
customEndpoint. A Dataset is the one place we use this option in the event a user is trying to communicate with their own Datastore server.We were skipping the auth when:
A user instantiated a Dataset providing an
apiEndpointoption:But, we also need to support when:
DATASTORE_HOSTenv var setWe have had half of the puzzle solved; we detect the presence of that env var and send the API requests to it accordingly. But, we forgot to update
customEndpoint, the option that skips authenticating.// @brainsiq