Benchmark: comparison cloud Logging latency between the pure gRPC/REST and the veneer gRPC/REST #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
It just show the whole running time for pure-gRPC/venner-gRPC/pure-REST/veneer-REST. Divided by number is the average latency. |
ZhouyihaiDing
changed the title
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 12, 2022
Source-Link: googleapis/googleapis@fd16b6a Source-Link: googleapis/googleapis-gen@d935b98 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 14, 2022
Source-Link: googleapis/googleapis@fd16b6a Source-Link: googleapis/googleapis-gen@d935b98 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9 fix(compute): replace missing REQUIRED for parent_id (#711) Source-Link: googleapis/googleapis@4bb6fd6 Source-Link: googleapis/googleapis-gen@c7d0653 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYzdkMDY1MzNiZTZlMjQ3MGUzNmI5ZjM1MWFlNGZmNDc5YTQ3ZGM1MyJ9 feat: update compute API to revision 20220322 (#710) Source-Link: googleapis/googleapis@68ad73b Source-Link: googleapis/googleapis-gen@a581672 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYTU4MTY3MjA2MWI5NDgxYzAxOTJkZTAzYmJmYTM0NjRlMDIzMzgxMSJ9 fix: fix breaking changes in Compute API (#701) Source-Link: googleapis/googleapis@272c110 Source-Link: googleapis/googleapis-gen@4c674ff Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiNGM2NzRmZjZmZGIyYmE1OGVmY2M0ZTc5Y2RkODIyNGI2ZTA0ZGE5NCJ9 feat: update compute API to revision 20220112 (#700) Source-Link: googleapis/googleapis@249e9a1 Source-Link: googleapis/googleapis-gen@1f2c41b Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiMWYyYzQxYmJmZTA5NzYxNmNlYjFlOWZiNjc4NzJhNmJiMWRjNTlkNCJ9
1 task
dwsupplee
pushed a commit
that referenced
this pull request
Apr 27, 2022
…714) (#5113) * fix(compute): remove proto3_optional from parent_id (#712) Source-Link: googleapis/googleapis@fd16b6a Source-Link: googleapis/googleapis-gen@d935b98 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9 fix(compute): replace missing REQUIRED for parent_id (#711) Source-Link: googleapis/googleapis@4bb6fd6 Source-Link: googleapis/googleapis-gen@c7d0653 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYzdkMDY1MzNiZTZlMjQ3MGUzNmI5ZjM1MWFlNGZmNDc5YTQ3ZGM1MyJ9 feat: update compute API to revision 20220322 (#710) Source-Link: googleapis/googleapis@68ad73b Source-Link: googleapis/googleapis-gen@a581672 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYTU4MTY3MjA2MWI5NDgxYzAxOTJkZTAzYmJmYTM0NjRlMDIzMzgxMSJ9 fix: fix breaking changes in Compute API (#701) Source-Link: googleapis/googleapis@272c110 Source-Link: googleapis/googleapis-gen@4c674ff Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiNGM2NzRmZjZmZGIyYmE1OGVmY2M0ZTc5Y2RkODIyNGI2ZTA0ZGE5NCJ9 feat: update compute API to revision 20220112 (#700) Source-Link: googleapis/googleapis@249e9a1 Source-Link: googleapis/googleapis-gen@1f2c41b Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiMWYyYzQxYmJmZTA5NzYxNmNlYjFlOWZiNjc4NzJhNmJiMWRjNTlkNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(compute): revert proto3_optional, required removal on parent_id (#714) Source-Link: googleapis/googleapis@6b3fdce Source-Link: googleapis/googleapis-gen@832dbe9 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiODMyZGJlOTk4ODc4ZDg2MTlkNmI0MGZlNTdjNmQyY2M2ZTdkYzkwYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Recently I created gRPC stub directly from Google\Logging\V2\LoggingServiceV2GrpcClient and used curl as pure REST to test the cloud Logging. It compared the unary ping-pong against Veneer version I copied from test/perf/LoggingPerfTest.php while setting the batchSize to 1 to make sure every log entry uses one unray ping-pong.
I got the result with 50 ping-pong warm-up and 1000 ping-pong benchmark on 1 core and 8 cores GCE VM and saved it in a doc. The result seems make sense to me. Do I need to post them here or share the link?
Also, I am a beginner of php and don't know the right place to place this code. I can push it to gRPC repo instead, but can you have a look at it? I am trying to make the comparison as fair as possible(like introduce buildEntry method which are done by Veneer). I hope I can get the some suggestions about the correctness of this benchmark.
Thank you!.