Skip to content

Commit

Permalink
Fixes #8545 by removing typing information for kwargs to not conflict…
Browse files Browse the repository at this point in the history
… with type checkers
  • Loading branch information
dpebot committed Jul 1, 2019
1 parent 226cdf1 commit 29da539
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion core/google/cloud/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ def from_service_account_json(cls, json_credentials_path, *args, **kwargs):
:type args: tuple
:param args: Remaining positional arguments to pass to constructor.
:type kwargs: dict
:param kwargs: Remaining keyword arguments to pass to constructor.
:rtype: :class:`_ClientFactoryMixin`
Expand Down
2 changes: 0 additions & 2 deletions datastore/google/cloud/datastore/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,6 @@ def batch(self):
def transaction(self, **kwargs):
"""Proxy to :class:`google.cloud.datastore.transaction.Transaction`.
:type kwargs: dict
:param kwargs: Keyword arguments to be passed in.
"""
return Transaction(self, **kwargs)
Expand Down Expand Up @@ -633,7 +632,6 @@ def do_something(entity):
>>> query_iter.next_page_token is None
True
:type kwargs: dict
:param kwargs: Parameters for initializing and instance of
:class:`~google.cloud.datastore.query.Query`.
Expand Down
1 change: 0 additions & 1 deletion datastore/google/cloud/datastore/key.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ class Key(object):
:param path_args: May represent a partial (odd length) or full (even
length) key path.
:type kwargs: dict
:param kwargs: Keyword arguments to be passed in.
Accepted keyword arguments are
Expand Down
2 changes: 0 additions & 2 deletions monitoring/google/cloud/monitoring_v3/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,6 @@ def select_resources(self, *args, **kwargs):
conjunction. If just one is provided and no keyword arguments
are provided, it can be a disjunction.
:type kwargs: dict
:param kwargs: Label filters to include in the conjunction as
described above.
Expand Down Expand Up @@ -309,7 +308,6 @@ def select_metrics(self, *args, **kwargs):
conjunction. If just one is provided and no keyword arguments
are provided, it can be a disjunction.
:type kwargs: dict
:param kwargs: Label filters to include in the conjunction as
described above.
Expand Down
2 changes: 0 additions & 2 deletions spanner/google/cloud/spanner_v1/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def _new_session(self):
def session(self, **kwargs):
"""Check out a session from the pool.
:type kwargs: dict
:param kwargs: (optional) keyword arguments, passed through to
the returned checkout.
Expand Down Expand Up @@ -505,7 +504,6 @@ class SessionCheckout(object):
:class:`~google.cloud.spanner_v1.session.AbstractSessionPool`
:param pool: Pool from which to check out a session.
:type kwargs: dict
:param kwargs: extra keyword arguments to be passed to :meth:`pool.get`.
"""

Expand Down
1 change: 0 additions & 1 deletion storage/google/cloud/storage/bucket.py
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,6 @@ def get_blob(
:param generation: Optional. If present, selects a specific revision of
this object.
:type kwargs: dict
:param kwargs: Keyword arguments to pass to the
:class:`~google.cloud.storage.blob.Blob` constructor.
Expand Down

0 comments on commit 29da539

Please sign in to comment.