Add handling of missing properties in SchemaField.from_api_repr() (#4754

)
googleapis · Jan 18, 2018 · 321e1f3 · 321e1f3
1 parent 95aaa50
commit 321e1f3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/bigquery/google/cloud/bigquery/schema.py b/bigquery/google/cloud/bigquery/schema.py
@@ -56,10 +56,13 @@ def from_api_repr(cls, api_repr):
             google.cloud.biquery.schema.SchemaField:
                 The ``SchemaField`` object.
         """
+        # Handle optional properties with default values
+        mode = api_repr.get('mode', 'NULLABLE')
+        fields = api_repr.get('fields', ())
         return cls(
             field_type=api_repr['type'].upper(),
-            fields=[cls.from_api_repr(f) for f in api_repr.get('fields', ())],
-            mode=api_repr['mode'].upper(),
+            fields=[cls.from_api_repr(f) for f in fields],
+            mode=mode.upper(),
             name=api_repr['name'],
         )
 

diff --git a/bigquery/tests/unit/test_schema.py b/bigquery/tests/unit/test_schema.py
@@ -102,6 +102,16 @@ def test_from_api_repr(self):
         self.assertEqual(field.fields[0].field_type, 'INTEGER')
         self.assertEqual(field.fields[0].mode, 'NULLABLE')
 
+    def test_from_api_repr_defaults(self):
+        field = self._get_target_class().from_api_repr({
+            'name': 'foo',
+            'type': 'record',
+        })
+        self.assertEqual(field.name, 'foo')
+        self.assertEqual(field.field_type, 'RECORD')
+        self.assertEqual(field.mode, 'NULLABLE')
+        self.assertEqual(len(field.fields), 0)
+
     def test_name_property(self):
         name = 'lemon-ness'
         schema_field = self._make_one(name, 'INTEGER')