Re-enable lint for tests, remove usage of pylint (#4921)

googleapis · Feb 24, 2018 · 804dccf · 804dccf
1 parent 7f4a584
commit 804dccf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/packages/google-cloud-vision/.flake8 b/packages/google-cloud-vision/.flake8
@@ -1,5 +1,11 @@
 [flake8]
 exclude =
+  # Exclude generated code.
+  **/proto/**
+  **/gapic/**
+  *_pb2.py
+
+  # Standard linting exemptions.
   __pycache__,
   .git,
   *.pyc,

diff --git a/packages/google-cloud-vision/nox.py b/packages/google-cloud-vision/nox.py
@@ -103,17 +103,9 @@ def lint(session):
     serious code quality issues.
     """
     session.interpreter = 'python3.6'
-    session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
+    session.install('flake8')
     session.install('.')
-    session.run('flake8', 'google/cloud/vision')
-    session.run(
-        'gcp-devrel-py-tools', 'run-pylint',
-        '--config', 'pylint.config.py',
-        '--library-filesets', 'google',
-        '--test-filesets', 'tests',
-        # Temporarily allow this to fail.
-        success_codes=range(0, 100))
-
+    session.run('flake8', 'google', 'tests')
 
 @nox.session
 def lint_setup_py(session):

diff --git a/packages/google-cloud-vision/tests/system.py b/packages/google-cloud-vision/tests/system.py
@@ -14,19 +14,15 @@
 
 """System tests for Vision API."""
 
-import functools
 import io
 import os
 import unittest
 
-import six
-
 from google.cloud import exceptions
 from google.cloud import storage
 from google.cloud import vision
 
 from test_utils.retry import RetryErrors
-from test_utils.retry import RetryResult
 from test_utils.system import unique_resource_id
 
 

diff --git a/packages/google-cloud-vision/tests/unit/test_helpers.py b/packages/google-cloud-vision/tests/unit/test_helpers.py
@@ -24,7 +24,6 @@
 from google.cloud.vision_v1 import types
 
 
-
 class TestSingleImageHelper(unittest.TestCase):
     def setUp(self):
         credentials = mock.Mock(spec=Credentials)