feat(billingbudgets): undeprecate resource name helper methods, add …

…2.7 deprecation warning (via synth) (#10038)
googleapis · Jan 8, 2020 · fd51c33 · fd51c33
1 parent 6c8e68e
commit fd51c33
Show file tree

Hide file tree

Showing 3 changed files with 3,431 additions and 17 deletions.
diff --git a/packages/google-cloud-billing-budgets/google/cloud/billing_budgets_v1beta1/__init__.py b/packages/google-cloud-billing-budgets/google/cloud/billing_budgets_v1beta1/__init__.py
@@ -16,12 +16,23 @@
 
 
 from __future__ import absolute_import
+import sys
+import warnings
 
 from google.cloud.billing_budgets_v1beta1 import types
 from google.cloud.billing_budgets_v1beta1.gapic import budget_service_client
 from google.cloud.billing_budgets_v1beta1.gapic import enums
 
 
+if sys.version_info[:2] == (2, 7):
+    message = (
+        "A future version of this library will drop support for Python 2.7."
+        "More details about Python 2 support for Google Cloud Client Libraries"
+        "can be found at https://cloud.google.com/python/docs/python2-sunset/"
+    )
+    warnings.warn(message, DeprecationWarning)
+
+
 class BudgetServiceClient(budget_service_client.BudgetServiceClient):
     __doc__ = budget_service_client.BudgetServiceClient.__doc__
     enums = enums

diff --git a/...cloud-billing-budgets/google/cloud/billing_budgets_v1beta1/gapic/budget_service_client.py b/...cloud-billing-budgets/google/cloud/billing_budgets_v1beta1/gapic/budget_service_client.py
@@ -83,24 +83,14 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def billing_account_path(cls, billing_account):
-        """DEPRECATED. Return a fully-qualified billing_account string."""
-        warnings.warn(
-            "Resource name helper functions are deprecated.",
-            PendingDeprecationWarning,
-            stacklevel=1,
-        )
+        """Return a fully-qualified billing_account string."""
         return google.api_core.path_template.expand(
             "billingAccounts/{billing_account}", billing_account=billing_account
         )
 
     @classmethod
     def budget_path(cls, billing_account, budget):
-        """DEPRECATED. Return a fully-qualified budget string."""
-        warnings.warn(
-            "Resource name helper functions are deprecated.",
-            PendingDeprecationWarning,
-            stacklevel=1,
-        )
+        """Return a fully-qualified budget string."""
         return google.api_core.path_template.expand(
             "billingAccounts/{billing_account}/budgets/{budget}",
             billing_account=billing_account,