Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt split repo: _python-domains_ #11027

Closed
vchudnov-g opened this issue Apr 4, 2023 · 0 comments
Closed

Adopt split repo: _python-domains_ #11027

vchudnov-g opened this issue Apr 4, 2023 · 0 comments
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:pending Split repo to be migrated has pending PRs migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 4, 2023 •
edited
Loading

Migrate the split-repo https://github.com/googleapis/python-domains to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:generated Split repo to be migrated here has generated samples migration:workaround:none Split repo to be migrated here has no manual workarounds migration:library:gapic_auto Library type of the split repo to be migrated here migration:testing:unit Split repo to be migrated here has unit tests migration:issues:none Split repo to be migrated here had no open issues when last checked labels Apr 4, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-domains Adopt split repo: _python-domains_ Apr 6, 2023
@vchudnov-g vchudnov-g added migration:ready migration:pr:none Split repo to be migrated has no pending PRs labels Apr 6, 2023
@atulep atulep assigned atulep and unassigned atulep Apr 10, 2023
This was referenced May 8, 2023
Closed
Closed
Closed
Closed
Merged
Closed
This was referenced May 31, 2023
Merged
Merged
@parthea parthea added migration:pr:pending Split repo to be migrated has pending PRs and removed migration:ready migration:pr:none Split repo to be migrated has no pending PRs labels Jun 1, 2023
vchudnov-g added a commit that referenced this issue Jun 1, 2023
@vchudnov-g
chore(migration): Migrate code from googleapis/python-domains into pa…
c4d0131 
…ckages/google-cloud-domains (#11206)

See #11027. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@vchudnov-g vchudnov-g added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:pending Split repo to be migrated has pending PRs migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parthea @vchudnov-g @atulep