Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default import for google.ai.generativelanguage to use v1beta3 #11676

Closed
parthea opened this issue Sep 20, 2023 · 0 comments · Fixed by #11677
Closed

Update the default import for google.ai.generativelanguage to use v1beta3 #11676

parthea opened this issue Sep 20, 2023 · 0 comments · Fixed by #11677
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Contributor

parthea commented Sep 20, 2023

See comment here requesting to update the default import for google.ai.generativelanguage to use google.ai.generativelanguage_v1beta3
@parthea parthea added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 20, 2023
@parthea parthea mentioned this issue Sep 20, 2023
Merged
parthea added a commit that referenced this issue Sep 21, 2023
@parthea
fix: set google.ai.generativelanguage_v1beta3 as the default import (#…
39ea699 
…11677)

Here are the steps that I followed to generate this PR

- Update the `default_version` in `.repo-metadata.json` here

https://github.com/googleapis/google-cloud-python/blob/eca60c3027820c97fc12590d0709b8fe3eb54034/packages/google-ai-generativelanguage/.repo-metadata.json#L14
- Work around the docs issue mentioned in
googleapis/gapic-generator-python#1776 by
applying this change locally
- Build the `v1beta2` and `v1beta3` clients locally in a clone of
[googleapis/googleapis](https://github.com/googleapis/googleapis) using
`bazel build
//google/ai/generativelanguage/v1beta3:ai-generativelanguage-v1beta2-py`
and `bazel build
//google/ai/generativelanguage/v1beta3:ai-generativelanguage-v1beta3-py`
- Run the docker containers for the owlbot copy-code and owlbot post
processor
```
 docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v /usr/local/google/home/partheniou/git/googleapis/bazel-bin:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --config-file=packages/google-apps-script-type/.OwlBot.yaml   --source-dir /bazel-bin --dest /repo
 ```
 
```
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo
gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
```

I also had to fix a bug in synthtool for the owlbot post processing: googleapis/synthtool#1861. Without this fix, the [docs/index.rst](https://github.com/googleapis/google-cloud-python/blob/main/packages/google-ai-generativelanguage/docs/index.rst) file would list `v1beta2` as the default import instead of `v1beta3`.

Fixes #11676 🦕
parthea added a commit that referenced this issue Sep 30, 2023
@parthea
See #11676 and googleapis/synthtool#1861
61dee31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set google.ai.generativelanguage_v1beta3 as the default import googleapis/google-cloud-python
1 participant
@parthea