Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add batch-like support for writing logs #1565

Closed
tseaver opened this issue Mar 3, 2016 · 4 comments
Closed

Should we add batch-like support for writing logs #1565

tseaver opened this issue Mar 3, 2016 · 4 comments
Assignees
@tseaver
Labels
api: logging Issues related to the Cloud Logging API. type: question Request for information or clarification. Not an issue.

Comments

@tseaver
Copy link
Contributor

tseaver commented Mar 3, 2016

The entries.write API allows sending multiple log entries per API request. Should we map this as a "batch" around a logger, similar to pubsub.topic.Batch?
@tseaver tseaver added type: question Request for information or clarification. Not an issue. api: logging Issues related to the Cloud Logging API. labels Mar 3, 2016
@tseaver tseaver mentioned this issue Mar 3, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Mar 7, 2016

The LogEntryOperation field provides a way to group entries corresponding to a single, logical operation. These might best be handled with a batch-like feature (see #1566).

@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

👍 Does it get sent with multi-part like storage batching?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2016

For entries.write, the entries field of the payload is a list.

For operations, I'm not even sure that they have to go in the same request: it appears that the back-end will group them based on id and producer, and use the first and last fields to figure out boundaries.

@tseaver tseaver mentioned this issue Mar 28, 2016
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Mar 30, 2016

Tracking the operation question on #1676. Batch added in #1665.

@tseaver tseaver closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: logging Issues related to the Cloud Logging API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @dhermes