Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'logger.Batch' for logging multiple entries via a single API call. #1665

Merged
merged 3 commits into from
Mar 28, 2016
Merged

Add 'logger.Batch' for logging multiple entries via a single API call. #1665

merged 3 commits into from
Mar 28, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 28, 2016

Can be used as a context manager.

See: #1565.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 28, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2016
dhermes
dhermes reviewed Mar 28, 2016
View reviewed changes
gcloud/logging/logger.py
class Batch(object):
"""Context manager: collect entries to log via a single API call.

Helper returned by :meth:Logger.batch

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2016

The docs error is one I haven't seen:

ImportError: No module named sphinx_rtd_theme

AFAIK sphinx_rtd_theme ships with Sphinx. If this error continues, we can move the import to where it is used.

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2016

UPDATE: I just checked, Sphinx and sphinx_rtd_theme haven't been updated recently (i.e. the last few days).

@tseaver
Copy link
Contributor Author

tseaver commented Mar 28, 2016

Maybe there was some transient failure to download the theme?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 28, 2016

Sphinx 1.4 (released today) is the cuprit. We now need to specify sphinx_rtd_theme ourselves.

@tseaver tseaver mentioned this pull request Mar 28, 2016
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Mar 28, 2016

Rebased after merging #1667 to master, and master to logging-api.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 28, 2016

@dhermes Any remaining issues?

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2016

LGTM

@tseaver tseaver merged commit fad7f4c into googleapis:logging-api Mar 28, 2016
@tseaver tseaver deleted the logging-multi_entry_batch branch March 28, 2016 17:52
@tseaver tseaver mentioned this pull request Mar 30, 2016
Closed
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot