Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION] What values should we use for our user agent? #2391

Closed
dhermes opened this issue Sep 22, 2016 · 6 comments
Closed

[QUESTION] What values should we use for our user agent? #2391

dhermes opened this issue Sep 22, 2016 · 6 comments
Assignees
@tseaver @theacodes
Labels
packaging type: question Request for information or clarification. Not an issue.

Comments

@dhermes
Copy link
Contributor

dhermes commented Sep 22, 2016

This came up in #2367. In node, they use gcloud-node-{SERVICE}/{SERVICE_VERSION}. So for example, bigtable would be gcloud-node-bigtable/0.3.1.

/cc @callmehiphop @stephenplusplus
@dhermes dhermes added type: question Request for information or clarification. Not an issue. packaging labels Sep 22, 2016
@theacodes
Copy link
Contributor

google-api-python client uses google-api-python-client/{version} (gzip), we should use similar:

google-cloud-python-{service}/{version} ({transport})

transport could, for example, be grpc, protobuf-over-http, json.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 22, 2016

@jonparrott See https://github.com/GoogleCloudPlatform/gcloud-common/issues/179#issuecomment-244605266 and https://github.com/GoogleCloudPlatform/gcloud-common/issues/179#issuecomment-244967800

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Sep 22, 2016
@dhermes
Changing user-agent to use the version from google-cloud-core.
c3a6fdc 
See googleapis#2391 for larger discussion.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Sep 22, 2016
@dhermes
Changing user-agent to use the version from google-cloud-core.
b2af5a1 
See googleapis#2391 for larger discussion.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Sep 22, 2016
@dhermes
Changing user-agent to use the version from google-cloud-core.
0cbd30b 
See googleapis#2391 for larger discussion.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Sep 23, 2016
@dhermes
Changing user-agent to use the version from google-cloud-core.
d995b8a 
See googleapis#2391 for larger discussion.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Sep 23, 2016
@dhermes
Changing user-agent to use the version from google-cloud-core.
30cc67c 
See googleapis#2391 for larger discussion.
This was referenced Sep 23, 2016
Merged
Closed
@tseaver
Copy link
Contributor

tseaver commented Feb 22, 2017

Should we update the USER_AGENT header to include the new __version__ headers added in #3046?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 22, 2017

@lukesneeringer Seemed to indicate that it wasn't as relevant. It might be a non-trivial code change? I'm not sure if the individual packages allow over-riding the user agent. At the very least it'd be a breaking change if we moved from self.USER_AGENT to a key-value pair in _EXTRA_HEADERS.

@lukesneeringer
Copy link
Contributor

Doing nothing is fine here.

@lukesneeringer
Copy link
Contributor

Also, oh hey, I bet this ticket is close-able. :-) #3046 pretty clearly supercedes it.

Closing. Re-open if there are any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

@theacodes theacodes

Labels
packaging type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lukesneeringer @jgeewax @tseaver @theacodes @dhermes