Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move duplicate ACL/metadata code in storage key/bucket into a subclass #262

Closed
dhermes opened this issue Oct 18, 2014 · 3 comments
Closed

Move duplicate ACL/metadata code in storage key/bucket into a subclass #262

dhermes opened this issue Oct 18, 2014 · 3 comments
Assignees
@dhermes
Labels
api: storage Issues related to the Cloud Storage API. 🚨 This issue needs some love. triage me I really want to be triaged.
Milestone
Storage Stable

Comments

@dhermes
Copy link
Contributor

dhermes commented Oct 18, 2014

See #238 discussion for details.

Work started in https://github.com/dhermes/gcloud-python/tree/refactor-key-bucket-shared-code and PR will be forthcoming
@dhermes dhermes self-assigned this Oct 18, 2014
@dhermes dhermes mentioned this issue Oct 19, 2014
Merged
@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Oct 20, 2014
@tseaver tseaver mentioned this issue Oct 31, 2014
Closed
@tseaver
Copy link
Contributor

tseaver commented Oct 31, 2014

Per #318 (comment) and previous notes, we now believe that the ACL-related APIs for buckets / keys should be moved to their relevant ACL classes. See #324.

@tseaver
Copy link
Contributor

tseaver commented Nov 7, 2014

@dhermes isn't this one landed?

@dhermes
Copy link
Contributor Author

dhermes commented Nov 7, 2014

Yup, this is the mix-in.

@dhermes dhermes closed this as completed Nov 7, 2014
@jgeewax jgeewax modified the milestone: Storage Stable Jan 30, 2015
urshala pushed a commit to urshala/google-cloud-python that referenced this issue Jan 17, 2020
Enhancement googleapis#262
a5b5a3e 
Attachment: You can now add in memory files to attachments.
Pass a tuple (BytesIO instance, 'file name.png')

Attachment: The size property is now updated when saving the file to disk.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 [autoapprove] (#262)
c1d5e47 
Source-Link: https://github.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt [autoa…
a433e92 
…pprove] (#262)

Source-Link: https://github.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2
parthea pushed a commit that referenced this issue Jun 4, 2023
@release-please
chore(main): release 1.8.0 (#262)
1225f66 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): Noxfile recognizes that tests can live in a folder (#262)
77f2d7f 
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (#262)
2029350 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Jun 4, 2023
@parthea
chore: test minimum dependencies in python 3.7 (#262)
77a3f5f
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): run blacken session for all directories with a noxfile (…
a6b40f0 
…#262)

Source-Link: googleapis/synthtool@bc0de6e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39ad8c0570e4f5d2d3124a509de4fe975e799e2b97e0f58aed88f8880d5a8b60

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Jun 4, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#262)
cc59a3b 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gc…
1ce885e 
…p/templates/python_library/.kokoro (#262)

Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): add missing import for prerelease testing (#262)
c011d8e 
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump cryptography to 41.0.0 [autoapprove] (#262)
19d0e17 
Source-Link: https://github.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore: use python-samples-reviewers (#262)
d5c47bd
parthea pushed a commit that referenced this issue Jun 4, 2023
@release-please
chore(main): release 2.9.1 (#262)
b5f89f7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jul 6, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.63.2 (#262)
47d86d0 
* chore: use gapic-generator-python 0.63.2
docs: add generated snippets

PiperOrigin-RevId: 427792504

Source-Link: googleapis/googleapis@55b9e1e

Source-Link: googleapis/googleapis-gen@bf4e86b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY0ZTg2Yjc1M2Y0MmNiMGVkYjFmZDUxZmJlODQwZDdkYTBhMWNkZSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Aug 15, 2023
@renovate-bot
chore(deps): update dependency google-cloud-iam to v2.11.1 (#262)
35342d8
parthea pushed a commit that referenced this issue Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-video-transcoder to v1.5.0 (
7863b1b 
#262)
parthea added a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#262)
ce26495 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: use python-samples-reviewers (#262)
9fd1c0a
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: add prerelease nox session (#262)
2a59c09 
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@busunkim96
chore: reference main branch of google-cloud-python (#262)
261af73
parthea pushed a commit that referenced this issue Sep 22, 2023
@release-please
chore: release 3.2.4 (#262)
b9a2a28 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.2.4](https://www.github.com/googleapis/python-dlp/compare/v3.2.3...v3.2.4) (2021-10-05)


### Bug Fixes

* improper types in pagers generation ([164977f](https://www.github.com/googleapis/python-dlp/commit/164977fda1fff85a245869ff197c3ca9f200f544))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#262)
1d5af39 
Source-Link: https://github.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea added a commit that referenced this issue Sep 22, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#262)
be1b18e 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this issue Sep 22, 2023
@parthea
fix(deps): require protobuf <4.0.0dev (#262)
41bf9b3
parthea added a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot @parthea
chore: Adding support for pytest-xdist and pytest-parallel (#262)
31f32a4 
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2 (#262)
4082592
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
feat: Release of relationships in v1, Add content type Relationship t…
8744712 
…o support relationship export (#262)

* feat: Release of relationships in v1, Add content type Relationship to support relationship export Committer: lvv@

PiperOrigin-RevId: 391065985

Source-Link: googleapis/googleapis@b9e69f8

Source-Link: googleapis/googleapis-gen@6d0f250

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore: release 3.4.0 (#265)
d54361a 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/python-asset/compare/v3.3.0...v3.4.0) (2021-08-17)


### Features

* Release of relationships in v1, Add content type Relationship to support relationship export  ([#262](https://www.github.com/googleapis/python-asset/issues/262)) ([93c92c1](https://www.github.com/googleapis/python-asset/commit/93c92c150581d22ff2f7b63d7591b3a97191ff20))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2.3.0 (#262)
3dd1e81
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.1 (#262)
e0712c3
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(python): add license header to auto-label.yaml (#262)
a8e006a 
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-vision to v2.4.4 (#262)
8600956
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-vision to v2.6.1 (#262)
f051f94
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.3 (#262)
f2a8e91
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: resolve issue with prerelease presubmit [autoapprove] (#262)
f73f15a 
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
parthea pushed a commit that referenced this issue Oct 21, 2023
@aribray
fix: remove unnecessary double quotes in strings (#262)
5251be6 
Change-Id: I79373e42991c2872ff0f8be215bbfa5b4b460f0c
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore: release 2.5.1 (#267)
095e864 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.5.1](https://www.github.com/googleapis/python-automl/compare/v2.5.0...v2.5.1) (2021-10-20)


### Bug Fixes

* remove unnecessary double quotes in strings ([#262](https://www.github.com/googleapis/python-automl/issues/262)) ([fb73bd7](https://www.github.com/googleapis/python-automl/commit/fb73bd7d5ab024aaec3bb0d892c587082911970b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore: [autoapprove] bump cryptography from 41.0.3 to 41.0.4 (#262)
84dbc7b 
Source-Link: googleapis/synthtool@dede53f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#262)
933507c 
Source-Link: https://github.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: storage Issues related to the Cloud Storage API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
Storage Stable
Development

No branches or pull requests
4 participants
@jgeewax @tseaver @dhermes @yoshi-automation