Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The value of more_results from storage.Connection.run_query should not be thrown away. #280

Closed
dhermes opened this issue Oct 22, 2014 · 5 comments · Fixed by #287
Closed

The value of more_results from storage.Connection.run_query should not be thrown away. #280

dhermes opened this issue Oct 22, 2014 · 5 comments · Fixed by #287
Assignees
@tseaver
Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dhermes
Copy link
Contributor

dhermes commented Oct 22, 2014

I'm currently writing a regression test that checks for more items after a fetch with a limit set and this boolean would determine if the next fetch (at the final cursor) contains all the remaining results.

As a side note, the Node regression needlessly re-queries with a cursor which (should) point to the end of the kind.

/cc @silvolu
@dhermes dhermes added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: datastore Issues related to the Datastore API. labels Oct 22, 2014
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Oct 22, 2014
@dhermes
Adding support for queries in regression test.
99f00f3 
This is an attempt port the gcloud-node regression tests
for queries over to gcloud-python.

This surfaced some API differences (i.e. issue googleapis#280)
and some missing features (projection, offset and group_by).

In addition, __eq__ was implemented on datastore.key.Key
to allow for easy comparison within tests.
@dhermes dhermes mentioned this issue Oct 22, 2014
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Oct 22, 2014
@dhermes
Adding support for queries in regression test.
1d1b147 
This is an attempt port the gcloud-node regression tests
for queries over to gcloud-python.

This surfaced some API differences (i.e. issue googleapis#280)
and some missing features (projection, offset and group_by).

In addition, __eq__ was implemented on datastore.key.Key
to allow for easy comparison within tests.
@silvolu
Copy link
Contributor

silvolu commented Oct 22, 2014

@dhermes the reason for that is described in this issue (basically it doesn't really work as you'd expect).

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Oct 22, 2014
@dhermes
Adding support for queries in regression test.
ccec7be 
This is an attempt port the gcloud-node regression tests
for queries over to gcloud-python.

This surfaced some API differences (i.e. issue googleapis#280)
and some missing features (projection, offset and group_by).

In addition, __eq__ was implemented on datastore.key.Key
to allow for easy comparison within tests.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Oct 22, 2014
@dhermes
Adding support for queries in regression test.
f26dfc5 
This is an attempt port the gcloud-node regression tests
for queries over to gcloud-python.

This surfaced some API differences (i.e. issue googleapis#280)
and some missing features (projection, offset and group_by).

In addition, __eq__ was implemented on datastore.key.Key
to allow for easy comparison within tests.
@dhermes
Copy link
Contributor Author

dhermes commented Oct 23, 2014

@silvolu Are you saying that googleapis/google-cloud-node#5 says that more_results is not a value that can be consistently trusted? Only @rakyll's issue description mentions the value of more_results.

UPDATE: FWIW I tested this on #281 and more_results was always equal to 2, irrespective of the query, which is the enum value of MORE_RESULTS_AFTER_LIMIT.

@silvolu
Copy link
Contributor

silvolu commented Oct 23, 2014

The backend keeps returning MORE_RESULTS_AFTER_LIMIT even when there are none.

@dhermes
Copy link
Contributor Author

dhermes commented Oct 23, 2014

Cool. I'd like to add this to the code as a comment and a reference to this issue. SG?

@silvolu
Copy link
Contributor

silvolu commented Oct 23, 2014

SGTM

@dhermes dhermes mentioned this issue Oct 23, 2014
Merged
@dhermes dhermes mentioned this issue Nov 11, 2014
Merged
@dhermes dhermes mentioned this issue Dec 17, 2014
Closed
@jgeewax jgeewax modified the milestone: Datastore Stable Jan 30, 2015
atulep pushed a commit that referenced this issue Apr 3, 2023
@release-please
chore: release 2.11.1 (#280)
f2ee5dd 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.11.1](https://www.github.com/googleapis/python-speech/compare/v2.11.0...v2.11.1) (2021-11-01)


### Bug Fixes

* **deps:** drop packaging dependency ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
* **deps:** require google-api-core >= 1.28.0 ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))


### Documentation

* list oneofs in docstring ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
atulep pushed a commit that referenced this issue Apr 6, 2023
@release-please
chore: release 2.11.1 (#280)
d2444ab 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.11.1](https://www.github.com/googleapis/python-speech/compare/v2.11.0...v2.11.1) (2021-11-01)


### Bug Fixes

* **deps:** drop packaging dependency ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
* **deps:** require google-api-core >= 1.28.0 ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))


### Documentation

* list oneofs in docstring ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
atulep pushed a commit that referenced this issue Apr 6, 2023
@release-please
chore: release 2.11.1 (#280)
aa62a89 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.11.1](https://www.github.com/googleapis/python-speech/compare/v2.11.0...v2.11.1) (2021-11-01)


### Bug Fixes

* **deps:** drop packaging dependency ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
* **deps:** require google-api-core >= 1.28.0 ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))


### Documentation

* list oneofs in docstring ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
atulep pushed a commit that referenced this issue Apr 18, 2023
@release-please
chore: release 2.11.1 (#280)
2697918 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.11.1](https://www.github.com/googleapis/python-speech/compare/v2.11.0...v2.11.1) (2021-11-01)


### Bug Fixes

* **deps:** drop packaging dependency ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
* **deps:** require google-api-core >= 1.28.0 ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))


### Documentation

* list oneofs in docstring ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#280)
832f647 
Source-Link: https://github.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea added a commit that referenced this issue Jun 4, 2023
@renovate-bot @parthea
chore(deps): update dependency google-cloud-pubsub to v2.14.0 (#280)
9c2f385 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore: update copyright year to 2022 (#280)
2e3d042 
* chore: update copyright year to 2022

PiperOrigin-RevId: 431037888

Source-Link: googleapis/googleapis@b3397f5

Source-Link: googleapis/googleapis-gen@510b54e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this issue Jun 4, 2023
@renovate-bot @parthea @gcf-owl-bot
chore(deps): update all dependencies (#280)
b90dcf1 
* chore(deps): update all dependencies

* revert

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(samples): Add check for tests in directory (#280)
579eeb3 
Source-Link: googleapis/synthtool@52aef91
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-datalabeling to v1.6.2 (#280
1784910 
)
parthea added a commit that referenced this issue Aug 15, 2023
@renovate-bot @parthea
chore(deps): update dependency flask to v2.1.0 (#280)
f787a27 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Sep 20, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#280)
5bd43f0 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@parthea
chore: migrate to owl bot (#280)
ce0dec9
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
feat: Add support for python 3.11 (#280)
4301a6f 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@release-please
chore(main): release 3.6.0 (#280)
bc638e4 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: add prerelease nox session (#280)
c955f10 
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-container to v2.11.2 (#280)
71cec05
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v1.42.3 (#280)
2e4955c
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
fix: Add async context manager return types (#280)
b002edf 
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: resolve issue with prerelease presubmit [autoapprove] (#280)
1f4f678 
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore(python): add license header to auto-label.yaml (#280)
69a26a3 
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v2.26.0 (#280)
8ee6b19
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.65.3 (#280)
cee5bfe 
* chore: use gapic-generator-python 0.65.3

PiperOrigin-RevId: 446591767

Source-Link: googleapis/googleapis@e24febc

Source-Link: googleapis/googleapis-gen@3b4f1d3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2I0ZjFkMzExMjY2YWVhMzJlMmJlOWI5ZmUzY2U3NDI3OTU4NzUzMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: regenerate samples (#280)
80a8610 
* chore(bazel): update protobuf to v3.21.7

PiperOrigin-RevId: 477955264

Source-Link: googleapis/googleapis@a724450

Source-Link: googleapis/googleapis-gen@4abcbca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-automl to v2.5.2 (#280)
cddad35
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#280)
b2bd26b 
Source-Link: https://github.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
parthea pushed a commit that referenced this issue Oct 22, 2023
@release-please
chore: release 2.11.1 (#280)
ca248a3 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.11.1](https://www.github.com/googleapis/python-speech/compare/v2.11.0...v2.11.1) (2021-11-01)


### Bug Fixes

* **deps:** drop packaging dependency ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
* **deps:** require google-api-core >= 1.28.0 ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))


### Documentation

* list oneofs in docstring ([43f25c0](https://www.github.com/googleapis/python-speech/commit/43f25c0612ef5b88f848b13ae42f711a4fc2d72a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore(python): update release script dependencies [autoapprove] (#280)
445749e 
Source-Link: https://github.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documenting the fact the more_results is unfit for use in datastore. dhermes/google-cloud-python
4 participants
@jgeewax @tseaver @dhermes @silvolu