Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return integer or None from 'Query.total_rows' #3004

Closed
tseaver opened this issue Feb 13, 2017 · 0 comments
Closed

Return integer or None from 'Query.total_rows' #3004

tseaver opened this issue Feb 13, 2017 · 0 comments
Assignees
@tseaver
Labels
api: bigquery Issues related to the BigQuery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Feb 13, 2017

Split out from #3001, where @amirshavit reported:

It would be 'nicer' if the total_rows property return an integer (or None) rather than a string.
@tseaver tseaver added api: bigquery Issues related to the BigQuery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 13, 2017
This was referenced Feb 13, 2017
Closed
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this issue May 6, 2017
@tseaver
Return int from 'total_rows'/'total_bytes_processed', if present.
7f83dc5 
Closes googleapis#3004.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: bigquery Issues related to the BigQuery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tseaver