Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision "manual" system tests are broken #3681

Closed
dhermes opened this issue Jul 26, 2017 · 4 comments
Closed

Vision "manual" system tests are broken #3681

dhermes opened this issue Jul 26, 2017 · 4 comments
Assignees
Labels
api: vision Issues related to the Cloud Vision API. testing

Comments

@dhermes
Copy link
Contributor

dhermes commented Jul 26, 2017

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2591

nox > Session system_tests(python_version='3.6') successful. :)
nox > Running session system_tests_manual_layer(python_version='2.7')
nox > virtualenv /var/code/gcp/.nox/system_tests_manual_layer-python_version-2-7 -p python2.7
nox > chdir /var/code/gcp/vision
nox > pip install --upgrade pytest ../core/ ../storage/
nox > pip install --upgrade ../test_utils/
nox > pip install --upgrade -e .
nox > py.test --quiet tests/system_old.py
............FFF................
=================================== FAILURES ===================================
_______________ TestVisionClientLabel.test_detect_labels_content _______________
Traceback (most recent call last):
  File "/var/code/gcp/vision/tests/system_old.py", line 368, in test_detect_labels_content
    self._assert_label(label)
  File "/var/code/gcp/vision/tests/system_old.py", line 357, in _assert_label
    self.assertIn(label.description, self.DESCRIPTIONS)
  File "/usr/local/lib/python2.7/unittest/case.py", line 803, in assertIn
    self.fail(self._formatMessage(msg, standardMsg))
  File "/usr/local/lib/python2.7/unittest/case.py", line 410, in fail
    raise self.failureException(msg)
AssertionError: u'motor vehicle' not found in ('car', 'vehicle', 'land vehicle', 'automotive design', 'wheel', 'automobile make', 'luxury vehicle', 'sports car', 'performance car', 'automotive exterior')
...
@dhermes dhermes added api: vision Issues related to the Cloud Vision API. build testing labels Jul 26, 2017
@lukesneeringer
Copy link
Contributor

This actually looks like the output changed.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 2, 2017

As of https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2688 / #3720, this is keeping is red.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 4, 2017

This is bothering me, so I'm fixing it right now (if I can in under 15m).

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Aug 4, 2017
Fixes googleapis#3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
@dhermes
Copy link
Contributor Author

dhermes commented Aug 4, 2017

Boom, 10 minutes!

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Aug 4, 2017
Fixes googleapis#3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
dhermes added a commit that referenced this issue Aug 4, 2017
Fixes #3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
landrito pushed a commit to landrito/google-cloud-python that referenced this issue Aug 21, 2017
…apis#3729)

Fixes googleapis#3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
landrito pushed a commit to landrito/google-cloud-python that referenced this issue Aug 22, 2017
…apis#3729)

Fixes googleapis#3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
landrito pushed a commit to landrito/google-cloud-python that referenced this issue Aug 22, 2017
…apis#3729)

Fixes googleapis#3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
parthea pushed a commit that referenced this issue Oct 21, 2023
Fixes #3681.

Also updating the `nox` configuration to allow posargs pass
through and be a little more Windows path friendly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. testing
Projects
None yet
Development

No branches or pull requests

2 participants