Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resumable uploads should try to send the file in one chunk by default #546

Closed
silvolu opened this issue Jan 14, 2015 · 0 comments · Fixed by #814
Closed

resumable uploads should try to send the file in one chunk by default #546

silvolu opened this issue Jan 14, 2015 · 0 comments · Fixed by #814
Assignees
@yoshi-automation
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Storage Stable

Comments

@silvolu
Copy link
Contributor

silvolu commented Jan 14, 2015

Sending data in one chunk is the recommended approach, documented in a not very clear way here in the “Uploading the file in chunks” section.

We should allow the user to override the chunk size, making sure that the library ends up using a multiple of 256 KB, as expected from the API (except for the final chunk that completes the upload where the size can vary according to the total size of the file). gsutil code dealing with this.
@silvolu silvolu added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Jan 14, 2015
@jgeewax jgeewax added this to the Storage Stable milestone Jan 30, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Feb 10, 2015
@dhermes
Make storage upload have no chunk size by default.
afc9994 
Fixes googleapis#546.
@dhermes dhermes mentioned this issue Feb 10, 2015
Closed
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Apr 9, 2015
@dhermes
Make storage upload/download have no chunk size by default.
c7d7d48 
Fixes googleapis#546.
@dhermes dhermes mentioned this issue Apr 9, 2015
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Apr 9, 2015
@dhermes
Make storage upload/download have no chunk size by default.
31dc5ae 
Fixes googleapis#546.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Apr 10, 2015
@dhermes
Make storage upload/download have no chunk size by default.
e442cd2 
Fixes googleapis#546.
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#546)
3c567eb 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@release-please
chore(main): release 2.15.1 (#546)
dcd235c 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore: [autoapprove] Update black and isort to latest versions (#546
4473fd5 
)

Source-Link: googleapis/synthtool@0c7b033
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Storage Stable
3 participants
@jgeewax @silvolu @yoshi-automation