Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: 'Blob.reload' does not pass encryption headers #7440

Closed
tseaver opened this issue Feb 25, 2019 · 0 comments
Closed

Storage: 'Blob.reload' does not pass encryption headers #7440

tseaver opened this issue Feb 25, 2019 · 0 comments
Assignees
@tseaver
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Feb 25, 2019

Per the docs on customer-supplied encryption keys, the X-Goog-Encryption-Key header applies not only the the blob / object's payload, but also to its CRC32c checksum and MD5 hash fields.

Blob.reload (inherited from _helpers._PropertyMixin does not pass those headers, and thus the returned resource will not have the crc32c or md5Hash fields set.
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 25, 2019
@tseaver tseaver self-assigned this Feb 25, 2019
@tseaver tseaver mentioned this issue Feb 25, 2019
Merged
tseaver added a commit that referenced this issue Mar 14, 2019
@tseaver
Ensure that 'Blob.reload' passes encryption headers. (#7441)
4fdbcc5 
Closes #7440.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tseaver