Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Topic.subscription factory #929

Closed
dhermes opened this issue Jun 17, 2015 · 1 comment
Closed

Implement Topic.subscription factory #929

dhermes opened this issue Jun 17, 2015 · 1 comment
Assignees
@dhermes
Labels
api: pubsub Issues related to the Pub/Sub API.
Milestone
Pub/Sub Alpha

Comments

@dhermes
Copy link
Contributor

dhermes commented Jun 17, 2015

See #910

I tried to implement in 1f80e36 but was not able to make the pylint god happy about the cyclic import.
@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label Jun 17, 2015
@dhermes dhermes added this to the Pub/Sub Alpha milestone Jun 17, 2015
@dhermes dhermes mentioned this issue Jun 17, 2015
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jun 17, 2015
@dhermes
Implementing topic.subscription factory.
920ed40 
Also using `topic.subscription` factory in docs and regression
tests instead of instantiating a `Subscription`.

Fixes googleapis#929.
Conflicts:
	docs/pubsub-usage.rst
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jun 17, 2015
@dhermes
Implementing topic.subscription factory.
e001902 
Also using `topic.subscription` factory in docs and regression
tests instead of instantiating a `Subscription`.

Fixes googleapis#929.
@dhermes dhermes mentioned this issue Jun 17, 2015
Merged
@dhermes
Copy link
Contributor Author

dhermes commented Jun 18, 2015

Closing since #912 exists

@dhermes dhermes closed this as completed Jun 18, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jun 25, 2015
@dhermes
Implementing topic.subscription factory.
cfe1b69 
Also using `topic.subscription` factory in docs and regression
tests instead of instantiating a `Subscription`.

Fixes googleapis#929.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jul 2, 2015
@dhermes
Implementing topic.subscription factory.
c03e7e0 
Also using `topic.subscription` factory in docs and regression
tests instead of instantiating a `Subscription`.

Fixes googleapis#929.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
Pub/Sub Alpha
Development

No branches or pull requests
1 participant
@dhermes