feat: add timeout parameter to Batch interface to match google-cloud-core #10010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
changed the title
busunkim96
reviewed
Dec 23, 2019
There was a problem hiding this comment.
It looks like CI is failing because of coverage dropping below 100%
coverage report --show-missing --fail-under=100
Name Stmts Miss Branch BrPart Cover Missing
----------------------------------------------------------------------------------
google/cloud/storage/__init__.py 8 0 0 0 100%
google/cloud/storage/_helpers.py 74 0 12 0 100%
google/cloud/storage/_http.py 15 0 2 0 100%
google/cloud/storage/_signing.py 145 0 70 0 100%
google/cloud/storage/acl.py 171 0 40 0 100%
google/cloud/storage/batch.py 129 2 28 2 97% 241->242, 242, 324->325, 325
google/cloud/storage/blob.py 450 0 140 0 100%
google/cloud/storage/bucket.py 530 0 168 0 100%
google/cloud/storage/client.py 163 0 56 0 100%
google/cloud/storage/constants.py 11 0 0 0 100%
google/cloud/storage/hmac_key.py 81 0 26 0 100%
google/cloud/storage/iam.py 23 0 0 0 100%
google/cloud/storage/notification.py 116 0 32 0 100%
tests/unit/__init__.py 0 0 0 0 100%
tests/unit/test__helpers.py 238 0 0 0 100%
tests/unit/test__http.py 44 0 0 0 100%
tests/unit/test__signing.py 409 0 52 0 100%
tests/unit/test_acl.py 669 0 2 0 100%
tests/unit/test_batch.py 386 0 6 0 100%
tests/unit/test_blob.py 2156 0 110 0 100%
tests/unit/test_bucket.py 2062 0 46 0 100%
tests/unit/test_client.py 679 0 10 0 100%
tests/unit/test_hmac_key.py 289 0 6 0 100%
tests/unit/test_notification.py 304 0 2 0 100%
----------------------------------------------------------------------------------
TOTAL 9152 2 808 2 99%
Command coverage report --show-missing --fail-under=100 failed with exit code 2
Session cover failed.
| subrequest = MIMEApplicationHTTP(method, uri, headers, body) | ||
| multi.attach(subrequest) | ||
| timeout = timeout |
There was a problem hiding this comment.
Nit: Could one of the timeouts be renamed? I had a little trouble figuring out what was happening here.
There was a problem hiding this comment.
oh, lord. My bad. Let me fix that. And my bad also, didn't run coverage locally.
There was a problem hiding this comment.
Related: I am defaulting to the timeout of the last request added to the batch. I could just as well see adding the timeouts up for each request in batch. Either seems like a fair enough approach.
tswast
approved these changes
Dec 26, 2019
There was a problem hiding this comment.
Thanks!
Re: taking the last vs adding them up. I have a slight preference for the current behavior of taking the last timeout value. Since the point of a batch request is to make only one HTTP request, I think it's more intuitive to take a single value rather than add them up.
This was referenced Jan 1, 2020
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
atalyaalon
added a commit
to data-for-change/anyway
that referenced
this pull request
Mar 6, 2020
@sagivharel - fix for timeout parameter: we had to make sure the google-cloud-core version and google-api-core versions are updated (issue: googleapis/google-cloud-python#9951 pr: googleapis/google-cloud-python#10010)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeout to google cloud storage batch interface and address breakage caused by interface incompatibility.
Fixes #10009
Related to #9915