Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix document of delete blob #10015

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #9985

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 24, 2019
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as there shouldn't be a return value on deletes.

Additionally, the API does not return the object resource on a delete operation as well.
https://cloud.google.com/storage/docs/json_api/v1/objects/delete

@crwilcox crwilcox merged commit 3bb565b into googleapis:master Jan 10, 2020
This was referenced Jan 29, 2020
@HemangChothani HemangChothani deleted the storage_fix_doc_blob_delete branch January 31, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: Blob.delete returns self.bucket.delete_blob but delete_blob returns nothing
5 participants