Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): fix minimum version of dependency #10016

Merged
merged 1 commit into from
Jan 9, 2020
Merged

fix(bigquery): fix minimum version of dependency #10016

merged 1 commit into from
Jan 9, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #10008

@HemangChothani HemangChothani requested review from tswast, crwilcox and a team December 24, 2019 13:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 24, 2019
@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Dec 26, 2019
plamut
plamut reviewed Dec 28, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have a question about a version bump that might not be immediately necessary (but will probably soon be).

bigquery/setup.py
"google-cloud-core >= 1.0.3, < 2.0dev",
"google-resumable-media >= 0.3.1, != 0.4.0, < 0.6.0dev",
"google-cloud-core >= 1.1.0, < 2.0dev",
"google-resumable-media >= 0.5.0, < 0.6dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version bump needed? Looking at the release notes, there have been no bugfixes since 0.3.1, and the only new feature is raw download classes (released in 0.5.0).

Not that I'm opposing it, just asking as a sanity check.

(besides, google-resumable-media version pin will have to be updated soon anyway when #10005 is implemented)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plamut Not any specific reason, for the raw download feature and found in setup.py file of storage so update it,so if you recommend i will revert back to 0.3.1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory not much has changed. And you could likely only take core (I am pretty sure given a recent change that is required). The grouping of resumable-media was to keep storage and bigquery in sync with what they require to hopefully avoid odd incompatibilities.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it appears safe, let's keep the resumable-media version bump then for the reason Chris mentioned.

@plamut plamut merged commit 0384238 into googleapis:master Jan 9, 2020
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
@HemangChothani HemangChothani deleted the bigquery_update_minimum_dependency_version branch January 31, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@plamut plamut plamut approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Dependency pins may be inadequate
5 participants
@HemangChothani @tswast @crwilcox @plamut @googlebot