Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add retry parameter to public methods where missing #10026

Merged
merged 2 commits into from
Jan 6, 2020
Merged

feat(bigquery): add retry parameter to public methods where missing #10026

merged 2 commits into from
Jan 6, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Dec 29, 2019

Fixes #10019.

This PR adds support for a retry to Client and Job methods where missing.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Dec 29, 2019
@plamut plamut requested a review from a team December 29, 2019 16:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2019
@plamut plamut merged commit de73e45 into googleapis:master Jan 6, 2020
@plamut plamut deleted the iss-10019 branch January 6, 2020 09:55
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: All timeoutable public methods should accept a retry argument
3 participants
@plamut @tswast @googlebot