Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(billingbudgets): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) #10038

Merged
merged 1 commit into from
Jan 8, 2020
Merged

feat(billingbudgets): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) #10038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions billingbudgets/google/cloud/billing_budgets_v1beta1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,23 @@


from __future__ import absolute_import
import sys
import warnings

from google.cloud.billing_budgets_v1beta1 import types
from google.cloud.billing_budgets_v1beta1.gapic import budget_service_client
from google.cloud.billing_budgets_v1beta1.gapic import enums


if sys.version_info[:2] == (2, 7):
message = (
"A future version of this library will drop support for Python 2.7."
"More details about Python 2 support for Google Cloud Client Libraries"
"can be found at https://cloud.google.com/python/docs/python2-sunset/"
)
warnings.warn(message, DeprecationWarning)


class BudgetServiceClient(budget_service_client.BudgetServiceClient):
__doc__ = budget_service_client.BudgetServiceClient.__doc__
enums = enums
Expand Down
14 changes: 2 additions & 12 deletions billingbudgets/google/cloud/billing_budgets_v1beta1/gapic/budget_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,24 +83,14 @@ def from_service_account_file(cls, filename, *args, **kwargs):

@classmethod
def billing_account_path(cls, billing_account):
"""DEPRECATED. Return a fully-qualified billing_account string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
"""Return a fully-qualified billing_account string."""
return google.api_core.path_template.expand(
"billingAccounts/{billing_account}", billing_account=billing_account
)

@classmethod
def budget_path(cls, billing_account, budget):
"""DEPRECATED. Return a fully-qualified budget string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
"""Return a fully-qualified budget string."""
return google.api_core.path_template.expand(
"billingAccounts/{billing_account}/budgets/{budget}",
billing_account=billing_account,
Expand Down
Loading