fix(logging): update test assertion and core version pins #10087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version bumps are needed, as timeouts were introduced to API core.
googlebot
added
the
cla: yes
2 tasks
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
An empty zone label that was missing is added.
plamut
commented
Jan 10, 2020
| @@ -179,7 +179,8 @@ def test_log_text_with_resource(self): | |||
| logger = Config.CLIENT.logger(self._logger_name("log_text_res")) | |||
| now = datetime.datetime.utcnow() | |||
| resource = Resource( | |||
| type="gae_app", labels={"module_id": "default", "version_id": "test"} | |||
| type="gae_app", | |||
| labels={"module_id": "default", "version_id": "test", "zone": ""}, | |||
There was a problem hiding this comment.
This is something that was already failing on master, does not seem to be caused by version bumps in this PR.
(I did not research when exactly the failure was introduced, though)
There was a problem hiding this comment.
I remember seeing something about this. It sounds like it changed fairly recently in the backend.
busunkim96
approved these changes
Jan 10, 2020
| @@ -179,7 +179,8 @@ def test_log_text_with_resource(self): | |||
| logger = Config.CLIENT.logger(self._logger_name("log_text_res")) | |||
| now = datetime.datetime.utcnow() | |||
| resource = Resource( | |||
| type="gae_app", labels={"module_id": "default", "version_id": "test"} | |||
| type="gae_app", | |||
| labels={"module_id": "default", "version_id": "test", "zone": ""}, | |||
There was a problem hiding this comment.
I remember seeing something about this. It sounds like it changed fairly recently in the backend.
This was referenced Jan 29, 2020
Merged
Merged
Merged
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #10088.
PR checklist