Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): add delivery attempt property to message object received by user code #10205

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

pradn
Copy link
Contributor

@pradn pradn commented Jan 24, 2020

  • Exposes the delivery-attempt counter for a message.
  • Add tests for plumbing + message property.
  • In the future, we should modify the system test test_creating_subscriptions_with_non_default_settings or create a new one to test setting a dead letter policy on a subscription. Such a modification would make the test fail now since DLQ isn't enabled for all projects. (Only a DLQ-enabled project would pass the modified test.)

Fixes #10161

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 24, 2020
@plamut plamut added the api: pubsub Issues related to the Pub/Sub API. label Jan 29, 2020
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, with the same thought on maybe returning None if delivery attempt is not applicable for a particular message.

Oh, and the commit message to make the linter happy. :)

@pradn pradn removed the request for review from anguillanneuf January 30, 2020 17:53
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradn pradn merged commit c3b9327 into googleapis:master Jan 30, 2020
@pradn pradn deleted the dlq branch January 30, 2020 22:03
This was referenced Jan 31, 2020
This was referenced Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: add support for dead letter topics
4 participants