Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): adjust test assertions to new default timeout #10251

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #10250

This PR adjusts a few unit test assertions to the new default timeout in core.

How to test

  • Run unit tests on the latest master branch.

Actual result (before the fix):
One test failed due to the timeout argument mismatch.

Expected result (after the fix):
All tests pass.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of that in the storage lib!

@plamut plamut merged commit 88e060f into googleapis:master Jan 30, 2020
@plamut plamut added the api: storage Issues related to the Cloud Storage API. label Jan 30, 2020
This was referenced Jan 30, 2020
@HemangChothani HemangChothani deleted the storage_test_assertion branch January 31, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: Adjust unit tests to the new default connection timeout in core
3 participants