Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cover.sh and folding into tox config. #1237

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 20, 2015

This is to make the tox config friendlier to Windows and other non-bash shells.

Towards #1123.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2015
@tseaver
Copy link
Contributor

tseaver commented Nov 20, 2015

Stray bigtable changes unrelated to the commit message.

@dhermes
Copy link
Contributor Author

dhermes commented Nov 20, 2015

That's scary. I wonder how that happened? Thanks. I'll ping once removed.

@tseaver
Copy link
Contributor

tseaver commented Nov 20, 2015

The two other changes (removing cover.sh and updating tox.ini) LGTM.

This is to make the tox config friendlier to Windows
and other non-bash shells.

Towards googleapis#1123.
@dhermes
Copy link
Contributor Author

dhermes commented Nov 20, 2015

Stripped out the stray changes. (I'm hoping I just did git checkout -b remove-bash-cover from the wrong branch by mistake, though it's strange it was folded into one commit.)

Will merge on Travis.

dhermes added a commit that referenced this pull request Nov 20, 2015
Removing cover.sh and folding into tox config.
@dhermes dhermes merged commit d57220c into googleapis:master Nov 20, 2015
@dhermes dhermes deleted the remove-bash-cover branch November 20, 2015 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants