Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Bigtable Cluster.update(). #1270

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 5, 2015

Also adding utility for processing UpdateClusterMetadata.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 5, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2015

self._operation_type = 'update'
self._operation_id, self._operation_begin = _process_operation(
cluster_pb.current_operation)

This comment was marked as spam.

This comment was marked as spam.

@tseaver
Copy link
Contributor

tseaver commented Dec 7, 2015

Good call! I'll implement an Operation class.

Do you mean to update this PR, or do one as a cleanup after merging this one (and #1270, #1271, #1272).

@dhermes
Copy link
Contributor Author

dhermes commented Dec 7, 2015

Will totally need to occur. Am teaching Python course all day, will try to get to it tonight.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 8, 2015

@tseaver Will send an Operation only PR and then fix this one and the undelete one

In the process of running final tests on the Operation code

@tseaver
Copy link
Contributor

tseaver commented Dec 8, 2015

Ping me after merging #1273 and updating.

Also adding utility for processing UpdateClusterMetadata.
@dhermes
Copy link
Contributor Author

dhermes commented Dec 9, 2015

@tseaver PTAL

@tseaver
Copy link
Contributor

tseaver commented Dec 9, 2015

LGTM

dhermes added a commit that referenced this pull request Dec 9, 2015
Implementing Bigtable Cluster.update().
@dhermes dhermes merged commit b4013b3 into googleapis:master Dec 9, 2015
@dhermes dhermes deleted the bigtable-cluster-update branch December 9, 2015 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants