Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Table.upload_from_file'. #1318

Merged
merged 9 commits into from
Jan 29, 2016
Merged

Add 'Table.upload_from_file'. #1318

merged 9 commits into from
Jan 29, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 22, 2015

Handles both single-request (multipart) and resumable uploads.

Closes #1261

@tseaver
Make 'job_from_resource' helper public.
5672636
@tseaver
Add 'Table.upload_from_file'.
5507266 
Handles both single-request (multipart) and resumable uploads.

Closes #1261
@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Dec 22, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2015
dhermes
dhermes reviewed Dec 22, 2015
View reviewed changes
gcloud/bigquery/client.py
@@ -102,20 +102,18 @@ def dataset(self, dataset_name):
"""
return Dataset(dataset_name, client=self)

def _job_from_resource(self, resource):
def job_from_resource(self, resource):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Dec 22, 2015
View reviewed changes
gcloud/bigquery/table.py
@@ -693,6 +699,225 @@ def insert_data(self,

return errors

@staticmethod
def _configure_job_metadata(metadata, # pylint: disable=R0913

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Jan 8, 2016
View reviewed changes
gcloud/bigquery/table.py
return client.job_from_resource(json.loads(response_content))


def _configure_job_metadata(metadata, # pylint: disable=R0913

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Jan 8, 2016
View reviewed changes
gcloud/bigquery/table.py
quote_character,
skip_leading_rows,
write_disposition):
"""Helper for :meth:`Table.upload_from_file`."""

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Jan 29, 2016
Merged
@dhermes
Copy link
Contributor

dhermes commented Jan 29, 2016

@tseaver LGTM to merge so we can get changes into 0.9.0, provided a follow up issue is filed and we get the issues resolved.

@tseaver tseaver mentioned this pull request Jan 29, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Jan 29, 2016

Follow up issue: #1431

tseaver added a commit that referenced this pull request Jan 29, 2016
@tseaver
Merge pull request #1318 from tseaver/1261-add_table_upload_multipart…
2095a06 
…_resumable

Add 'Table.upload_from_file'.
@tseaver tseaver merged commit 2095a06 into googleapis:master Jan 29, 2016
@tseaver tseaver deleted the 1261-add_table_upload_multipart_resumable branch January 29, 2016 19:02
@dhermes
Copy link
Contributor

dhermes commented Jan 29, 2016

@tseaver FYI gcloud.bigquery.test_table.TestTable.test_upload_from_file_w_bound_client_multipart fails on Windows.

This was referenced Jan 30, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot