Replace dataset id with project in datastore #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Dec 23, 2015
| return dataset_id1[2:] == dataset_id2 | ||
| elif dataset_id2.startswith('s~') or dataset_id2.startswith('e~'): | ||
| # Here we know `dataset_id1` is unprefixed and `dataset_id2` | ||
| if project1.startswith('s~') or project1.startswith('e~'): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
replace-dataset-id-with-project
branch
from
739e80b
to
584d44c
Compare
dhermes
force-pushed
the
replace-dataset-id-with-project
branch
3 times, most recently
from
d5b313f
to
d1bcb86
Compare
This was **very** deeply intertwined with tests, so there were many residual changes as a result.
Now they all send project instead of sending dataset_id for Query and Key.
dhermes
force-pushed
the
replace-dataset-id-with-project
branch
from
d1bcb86
to
b1d4895
Compare
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 14, 2016
Replace dataset id with project in datastore
|
Merging this after #1369 caused a system test error / lint issue in the datastore system tests. Sending PR ASAP. |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jan 14, 2016
Causes by googleapis#1330 and googleapis#1369 crossing paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in advance of
v1beta3wherePartitionId.dataset_idbecomesPartitionId.project_id.@tseaver This is part of the plan in #1288. It's a bit of a mouthful, maybe you have some suggestions on how to make it easier to review? (I'm happy to make the necessary changes)
Also note that I haven't changed the use of
GCLOUD_TESTS_DATASET_IDand similar for finding the default project. IMO that should come in a separate PR. I feel that that separate PR will be complicated enough without throwing in ALL these renames. (I also realized that we only check the env. var. for the project with every other service, though we could check the App Engine ID or the Compute Engine ID as well.)