Use googleapis common protos #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Jan 7, 2016
dhermes
force-pushed
the
use-googleapis-common-protos
branch
from
8edeeb9
to
621e354
Compare
tseaver
referenced
this pull request
in dhermes/google-cloud-python
Jan 14, 2016
This is in advance of `v1beta3`, where it will be needed to parse `Value.timestamp_value` (which is of type `timestamp_pb2.Timestamp`). Also adding `_datetime_to_pb_timestamp` for the other direction.
dhermes
force-pushed
the
use-googleapis-common-protos
branch
from
621e354
to
02553e6
Compare
dhermes
force-pushed
the
use-googleapis-common-protos
branch
from
02553e6
to
4def774
Compare
| """Write gRPC-only lines to custom module.""" | ||
| grpc_only_lines = get_pb2_grpc_only() | ||
| with open(GRPC_ONLY_FILE, 'wb') as file_obj: | ||
| file_obj.write(''.join(grpc_only_lines)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM, even if you decide not to address the earlier |
dhermes
force-pushed
the
use-googleapis-common-protos
branch
from
4def774
to
3a58fee
Compare
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jan 15, 2016
Caused by merging googleapis#1353 before googleapis#1329.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has #1317 as diffbase.H/T to @tbetbetbe who alerted me to the existence of https://pypi.python.org/pypi/googleapis-common-protos. w00t!