Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing merge.sh. #1364

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Removing merge.sh. #1364

merged 1 commit into from
Jan 7, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 7, 2016

No longer needed since update_wheels_project.sh is gone.

Towards #1123

No longer needed since `update_wheels_project.sh` is gone.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

@tseaver At what point do we feel comfortable deleting https://github.com/GoogleCloudPlatform/gcloud-python-wheels

@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2016

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

Thanks for LGTM. What about my question about deleting the wheels repo?

dhermes added a commit that referenced this pull request Jan 7, 2016
@dhermes dhermes merged commit dafc052 into googleapis:master Jan 7, 2016
@dhermes dhermes deleted the remove-merge-sh branch January 7, 2016 21:54
@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2016

I don't see any reason to keep it: there is no way to go "back in time" for failed Travis builds, or any other such debugging purpose, and I don't think we care about any outside users.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

OK. I'm going to set a reminder to do it next Monday (we can discuss at stand-up). The repo will self-destruct in 4 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants