Updating datastore system test to allow concurrent runs. #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
ds-system-test-namespace
branch
from
88abb42
to
4d5b224
Compare
This was referenced Jan 8, 2016
| if EMULATOR_DATASET is not None: | ||
| clear_datastore.remove_all_entities(client=Config.CLIENT) | ||
| Config.CLIENT = datastore.Client(dataset_id=EMULATOR_DATASET, | ||
| namespace=TEST_NAMESPACE) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
ds-system-test-namespace
branch
2 times, most recently
from
4cbeada
to
49f8a23
Compare
|
LuLz. Pushed a test key. |
Using a namespace for any key which is changed (inserted/deleted) so that concurrent tests don't operate on the same data. The one exception is `TestDatastoreQuery` which depends on entities which need to be already stored and indexed before running. For this test case, a new client is created without any namespace.
dhermes
force-pushed
the
ds-system-test-namespace
branch
from
49f8a23
to
6d85a03
Compare
| if EMULATOR_DATASET is not None: | ||
| clear_datastore.remove_all_entities(client=Config.CLIENT) | ||
| Config.CLIENT = datastore.Client(project=EMULATOR_DATASET, | ||
| namespace=TEST_NAMESPACE) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Jan 14, 2016
Updating datastore system test to allow concurrent runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a namespace for any key which is changed (inserted/deleted) so that concurrent tests don't operate on the same data. The one exception is
TestDatastoreQuerywhich depends on entities which need to be already stored and indexed before running. For this test case, a new client is created without any namespace.NOTE: Has #1369 as diffbase.
Inspired by #1363.