Adding Bigtable Row.increment_cell_value. #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -42,6 +42,43 @@ def __init__(self, row_key, table, filter_=None): | |||
| self._row_key = _to_bytes(row_key) | |||
| self._table = table | |||
| self._filter = filter_ | |||
| self._rule_pb_list = [] | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
bigtable-increment-cell-value
branch
2 times, most recently
from
724fd9d
to
ac6f9ae
Compare
Similar to googleapis#1388. The API accepts integers and then encodes them as bytes when stored in the table.
dhermes
force-pushed
the
bigtable-increment-cell-value
branch
from
ac6f9ae
to
51743b3
Compare
|
LGTM (in spite of the awkward diff). |
|
Sorry for the awkward diff. The 1st and 2nd commit aren't too bad, but when put together they are. I did the 2nd commit because I messed up the order when I rebased #1387. |
dhermes
added a commit
that referenced
this pull request
Jan 15, 2016
Adding Bigtable Row.increment_cell_value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1388. The API accepts integers and then encodes them as bytes when stored in the table.