Adding optional arguments to generate signed URI method. #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows customization of the experience for end users of the signed URI.
googlebot
added
the
cla: yes
|
|
||
| .. _Issue 922: https://github.com/GoogleCloudPlatform/\ | ||
| gcloud-python/issues/922 | ||
| .. _reference: https://cloud.google.com/storage/docs/reference-headers |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
|
@jgeewax I'm going to merge but still would like to hear what you have to say. |
dhermes
added a commit
that referenced
this pull request
Jan 28, 2016
Adding optional arguments to generate signed URI method.
This was referenced Jan 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows customization of the experience for end users of the signed URI.
I noticed googleapis/google-cloud-node#1058 and thought we should implement as well, at which point I realized we didn't support the response content type/disposition either.