-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging client #1422
Add logging client #1422
Conversation
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# pylint: disable=missing-docstring |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
del self.stub | ||
|
||
# Page descriptors | ||
_LIST_LOG_METRICS_DESCRIPTOR = page_descriptor.PageDescriptor( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
General comment: Having things like
just seems crazy to me. Why is it necessary to have a library to wrap a library? The stub also has generated methods exactly like the ones generated here. Why do we need generated methods to cover the already generated methods from gRPC? Aside: It also doesn't make it any easier to use |
Thanks for the feedback pass! |
Most general style nits addressed - the other issues we are tracking and intend to punt from this PR per offline discussion.
The other quickly solvable issue I'll address in the next PR is making stub a property. |
What is the goal for getting tests to pass here? We already have a fake gRPC for the Bigtable tests, so you might be able to get tests to pass by removing the dependencies that bring in |
""" | ||
Lists log entries. Use this method to retrieve log entries from Cloud | ||
Logging. For ways to export log entries, see | ||
[Exporting Logs](/logging/docs/export). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixed setup.py ordering |
No description provided.