Dropping _has_field. #1450
Merged
Dropping _has_field. #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can use value.HasField() for datastore v1beta2 and for datastore v1beta3 we can use Value.value_type (which is a oneof) along with WhichOneof.
dhermes
added
api: datastore
googlebot
added
the
cla: yes
|
/cc @jonparrott |
|
Feel free to assign PRs to me, it helps me remember to review them. |
|
Will do. That makes way more sense than cc-ing you! |
|
This LGTM, though my familiarity with grpc isn't as high as I'd like it to be to have confidence in my opinion here. |
|
Nothing gRPC happening here, just |
This was referenced Feb 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can use
value.HasField()for datastorev1beta2and for datastorev1beta3we can useValue.value_type(which is a oneof) along withWhichOneof.