Adding grpcio to setup.py as an extra.

[dhermes]

grpcio can only be installed with Python 2.7, so the py27 tox environment is the only one that doesn't need to run without mocks.

FYI @jgeewax the grpcio install fails on Python 2.6 and 3.4 (didn't try 3.5).

• This won't run Py2.7 tests on AppVeyor with grpcio but will at least install it. I tried to tackle but can't write faithful powershell without a test machine
• If this works, I'll conditionally add the Bigtable tests (in Py2.7) in attempt_system_tests.py

[theacodes]

Would it make sense to make this an extra?

[tseaver]

I like the idea of the extra: users can make perfectly valid use of gcloud without grpc.

[dhermes]

👍 I like the idea. Then we'd have

pip install gcloud[grpc]

for people that want to use gRPC?

---

@jgeewax Please weigh in

[theacodes]

Actually I think it's better for the extra to the the part of this library that requires extra dependencies. So IMO it should be pip install gcloud[bigtable].

[dhermes]

But in the not-too-distant future datastore, pubsub, logging, others? will have direct gRPC support in this library.

[theacodes]

Hmm. Fair point. I'm unsure. It seems that right now grpc doesn't have a good install story (unless that's recently changed).

One part of me is leaning on having grpc remain an "extra" (in one way or another) until the install story improves or the tipping point where most clients in this library use grpc.

@jgeewax what do you think?

[dhermes]

pip install grpcio>=0.13.0 works fairly well now, but must be 2.7 and only targets a limited number of platforms (but Linux, OS X and Windows covers a lot).

[theacodes]

That's fair, I suppose. Are any os-level dependencies needed other than just build-essential?

[dhermes]

No idea. @nathanielmanistaatgoogle do you know who might be able to chime in?

[jgeewax]

I don't think even build-essential is needed.... It shouldn't as there's no compiling so gcc and make shouldn't be required for this...

[theacodes]

Cool, SGTM.

[dhermes]

I'm about to test it on bare GCE Debian and Ubuntu images.

[dhermes]

Seems to work on Ubuntu:

$ sudo apt-get update
$ sudo apt-get -y upgrade
$ curl -O https://bootstrap.pypa.io/get-pip.py
$ sudo python get-pip.py
$ sudo -H pip install --upgrade pip
$ sudo -H pip install 'grpcio==0.13.0'
# FAILURE: https://gist.github.com/dhermes/f3cc291bb289ae69c86d
$ sudo -H pip install --upgrade six
$ sudo -H pip install 'grpcio==0.13.0'
$ # SUCCESS!
$ dpkg -s build-essential
dpkg-query: package 'build-essential' is not installed and no information is available
Use dpkg --info (= dpkg-deb --info) to examine archive files,
and dpkg --contents (= dpkg-deb --contents) to list their contents.

[dhermes]

Confirmed it works (with the same funky VersionConflict when --upgrade isn't used) on Debian

[dhermes]

@tseaver PTAL. Updated to make it an extra.

[tseaver]

LGTM

[tseaver]

grpc 0.13.0 is broken on UCS2 versions of python 2.7 (which you get when you build Python 2.x from source).

We should drop testing with it in tox until they make a release with the fix.

[dhermes]

@tseaver can you file an issue? I'm AFK right now

[tseaver]

#1572