Add 'Logger.log_text' method. #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| """Fully-qualified name used in logging APIs""" | ||
| return 'projects/%s/logs/%s' % (self.project, self.name) | ||
|
|
||
| def _require_client(self, client): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Done with review. |
|
Is that an |
|
Nope |
|
What issue remains, besides |
$ git grep -l _require_client
gcloud/bigquery/dataset.py
gcloud/bigquery/job.py
gcloud/bigquery/query.py
gcloud/bigquery/table.py
gcloud/dns/changes.py
gcloud/dns/zone.py
gcloud/pubsub/subscription.py
gcloud/pubsub/topic.py
gcloud/resource_manager/project.py
gcloud/search/document.py
gcloud/storage/_helpers.py
gcloud/storage/acl.py
gcloud/storage/blob.py
gcloud/storage/bucket.py |
|
LGTM. Sorry for the hold up, I was very distracted at that moment so didn't want to jump the gun. |
|
No worries! |
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…orm/python-docs-samples#1567) * Added the sample for Word Level Confidence * Added the extra line * Added parameter comment * Removed the line with blank space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't yet expose any of the optional parameters (see #1566).