Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Logger.log_text' method. #1567

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Add 'Logger.log_text' method. #1567

merged 1 commit into from
Mar 9, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 3, 2016

Doesn't yet expose any of the optional parameters (see #1566).

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 3, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 3, 2016
@tseaver tseaver mentioned this pull request Mar 3, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 7, 2016

@dhermes PTAL. I will rebase #1568 and assign to you after this one lands.

"""Fully-qualified name used in logging APIs"""
return 'projects/%s/logs/%s' % (self.project, self.name)

def _require_client(self, client):

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

Done with review.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2016

Is that an LGTM?

@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

Nope

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2016

What issue remains, besides _require_client, which we use all over the place?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2016

$ git grep -l _require_client
gcloud/bigquery/dataset.py
gcloud/bigquery/job.py
gcloud/bigquery/query.py
gcloud/bigquery/table.py
gcloud/dns/changes.py
gcloud/dns/zone.py
gcloud/pubsub/subscription.py
gcloud/pubsub/topic.py
gcloud/resource_manager/project.py
gcloud/search/document.py
gcloud/storage/_helpers.py
gcloud/storage/acl.py
gcloud/storage/blob.py
gcloud/storage/bucket.py

@dhermes
Copy link
Contributor

dhermes commented Mar 9, 2016

LGTM. Sorry for the hold up, I was very distracted at that moment so didn't want to jump the gun.

tseaver added a commit that referenced this pull request Mar 9, 2016
@tseaver tseaver merged commit b04eaa6 into googleapis:logging-api Mar 9, 2016
@tseaver tseaver deleted the logging-logger_log_text branch March 9, 2016 00:55
@tseaver
Copy link
Contributor Author

tseaver commented Mar 9, 2016

No worries!

atulep pushed a commit that referenced this pull request Apr 6, 2023
…orm/python-docs-samples#1567)

* Added the sample for Word Level Confidence

* Added the extra line

* Added parameter comment

* Removed the line with blank space
atulep pushed a commit that referenced this pull request Apr 6, 2023
…orm/python-docs-samples#1567)

* Added the sample for Word Level Confidence

* Added the extra line

* Added parameter comment

* Removed the line with blank space
atulep pushed a commit that referenced this pull request Apr 18, 2023
…orm/python-docs-samples#1567)

* Added the sample for Word Level Confidence

* Added the extra line

* Added parameter comment

* Removed the line with blank space
parthea pushed a commit that referenced this pull request Oct 22, 2023
…orm/python-docs-samples#1567)

* Added the sample for Word Level Confidence

* Added the extra line

* Added parameter comment

* Removed the line with blank space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants