Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding system tests for HappyBase Table.rows(). #1605

Merged
merged 2 commits into from
Mar 14, 2016
Merged

Adding system tests for HappyBase Table.rows(). #1605

merged 2 commits into from
Mar 14, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 12, 2016

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Mar 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2016
tseaver
tseaver reviewed Mar 12, 2016
View reviewed changes
system_tests/bigtable_happybase.py
table.put(ROW_KEY2, row2_data)

rows = table.rows([ROW_KEY1, ROW_KEY2])
rows.sort(key=_FIRST_ELT)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Mar 13, 2016

sorted() doesn't commit to having the source be an actual list. If that consideration is moot, then list.sort() is slightly more efficient (for big enough lists to make the cost of allocation measurable).

@dhermes
Copy link
Contributor Author

dhermes commented Mar 13, 2016

@tseaver PTAL

@dhermes
Copy link
Contributor Author

dhermes commented Mar 14, 2016

@tseaver Any issues here?

@tseaver
Copy link
Contributor

tseaver commented Mar 14, 2016

LGTM

dhermes added a commit that referenced this pull request Mar 14, 2016
@dhermes
Merge pull request #1605 from dhermes/sys-test-happybase-rows
fdae44a 
Adding system tests for HappyBase Table.rows().
@dhermes dhermes merged commit fdae44a into googleapis:master Mar 14, 2016
@dhermes dhermes deleted the sys-test-happybase-rows branch March 14, 2016 17:52
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot